refactor nems esmFldsExchange #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add werror to extbuild ### Description of changes Add werror to github testing - no gfortran warnings allowed. ### Specific notes Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) BFB Any User Interface Changes (namelist or namelist defaults changes)? NO ### Testing performed Testing performed if application target is CESM: - [ ] (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py - machines: - details (e.g. failed tests): - [ ] (recommended) CESM testlist_drv.xml - machines and compilers: - details (e.g. failed tests): - [X] (optional) CESM prealpha test - machines and compilers cheyenne, intel, gnu, github testing. - details (e.g. failed tests): - [ ] (other) please described in detail - machines and compilers - details (e.g. failed tests): Testing performed if application target is UFS-coupled: - [ ] (recommended) UFS-coupled testing - description: - details (e.g. failed tests): Testing performed if application target is UFS-HAFS: - [ ] (recommended) UFS-HAFS testing - description: - details (e.g. failed tests): ### Hashes used for testing: - [X] CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - branch/hash: cesm2_3_beta11 - [ ] UFS-coupled, then umbrella repostiory to check out and associated hash: - repository to check out: - branch/hash: - [ ] UFS-HAFS, then umbrella repostiory to check out and associated hash: - repository to check out: - branch/hash:
Add new XML variables for flexible controls of GPU configuration
implement ocean albedos for UFS
* this is required because of the code structure which calculates unbanded swpen (not used in ufs)
b4b for cpld, agrid, datm cases
* this adds some fields to mediator history files, with no impact on results
41 tasks
DeniseWorthen
requested review from
uturuncoglu,
junwang-noaa and
BrianCurtis-NOAA
uturuncoglu
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
@DeniseWorthen It looks good to me. Thanks for cleaning those if statements. I hope we could get rid of all of those in the future.
junwang-noaa
approved these changes
Sep 19, 2023
|
@DeniseWorthen testing is finished on ufs-wm #1894, please feel free to merge this sub-component PR when you're able. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Simplifies the field exchanges defined for the UFS. Nearly all coupling_mode specific blocks were removed within the fields exchange, as well as in a few locations in the generic CMEPS code. A single logical
med_aoflux_to_ocnwas introduced in the fields exchange which allowed the collapse of most logical if-else blocks. This is still not ideal, but isolates all changes to CMEPS and requires no changes in other components.Unnecessary trims on field names were also removed and comments were modified for consistency and simplification.