Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CMEPS for refactor of esmFldsExchange_nems #1894

Merged

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Sep 10, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

  • Clarifies the fields Exchange module for UFS in CMEPS by removing logical if-then blocks where possible.
  • Removes unecessary coupling_mode logical checks in CMEPS.
  • Makes required changes in the fd_nems.yaml file for UFS.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

All cpld and datm tests will need new baselines because of field name changes in the mediator restart files. All other comparisons for these tests are b4b. See below for the list of files which do not compare.

Non-reproducing files
tests/logs/log_hera: grep NOT rt_* 

rt_001_cpld_control_p8_mixedmode_intel.log:64: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_002_cpld_control_gfsv17_intel.log:63: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_003_cpld_control_p8_intel.log:64: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_005_cpld_control_qr_p8_intel.log:64: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_007_cpld_2threads_p8_intel.log:52: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_008_cpld_decomp_p8_intel.log:52: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_009_cpld_mpi_p8_intel.log:52: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_010_cpld_control_ciceC_p8_intel.log:64: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_011_cpld_control_c192_p8_intel.log:52: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-43200.nc ............ALT CHECK......NOT OK
rt_013_cpld_bmark_p8_intel.log:47: Comparing RESTART/ufs.cpld.cpl.r.2013-04-01-21600.nc ............ALT CHECK......NOT OK
rt_015_cpld_control_noaero_p8_intel.log:63: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_016_cpld_control_nowave_noaero_p8_intel.log:63: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_017_cpld_debug_p8_intel.log:52: Comparing RESTART/ufs.cpld.cpl.r.2021-03-22-32400.nc ............ALT CHECK......NOT OK
rt_018_cpld_debug_noaero_p8_intel.log:51: Comparing RESTART/ufs.cpld.cpl.r.2021-03-22-32400.nc ............ALT CHECK......NOT OK
rt_019_cpld_control_noaero_p8_agrid_intel.log:63: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_020_cpld_control_c48_intel.log:51: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_021_cpld_control_p8_faster_intel.log:64: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_022_cpld_control_pdlib_p8_intel.log:63: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_025_cpld_debug_pdlib_p8_intel.log:51: Comparing RESTART/ufs.cpld.cpl.r.2021-03-22-32400.nc ............ALT CHECK......NOT OK
rt_152_datm_cdeps_control_cfsr_intel.log:7: Comparing RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_154_datm_cdeps_control_gefs_intel.log:7: Comparing RESTART/DATM_GEFS_NEW.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_155_datm_cdeps_iau_gefs_intel.log:7: Comparing RESTART/DATM_GEFS_NEW.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_156_datm_cdeps_stochy_gefs_intel.log:7: Comparing RESTART/DATM_GEFS_NEW.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_157_datm_cdeps_ciceC_cfsr_intel.log:7: Comparing RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_158_datm_cdeps_bulk_cfsr_intel.log:7: Comparing RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_159_datm_cdeps_bulk_gefs_intel.log:7: Comparing RESTART/DATM_GEFS_NEW.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_160_datm_cdeps_mx025_cfsr_intel.log:10: Comparing RESTART/DATM_CFSR.cpl.r.2011-10-01-43200.nc ............ALT CHECK......NOT OK
rt_161_datm_cdeps_mx025_gefs_intel.log:10: Comparing RESTART/DATM_GEFS_NEW.cpl.r.2011-10-01-43200.nc ............ALT CHECK......NOT OK
rt_162_datm_cdeps_multiple_files_cfsr_intel.log:5: Comparing RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_163_datm_cdeps_3072x1536_cfsr_intel.log:7: Comparing RESTART/DATM_CFSR3072x1536.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_164_datm_cdeps_gfs_intel.log:7: Comparing RESTART/DATM_GFS.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_165_datm_cdeps_debug_cfsr_intel.log:7: Comparing RESTART/DATM_CFSR.cpl.r.2011-10-01-21600.nc ............ALT CHECK......NOT OK
rt_166_datm_cdeps_control_cfsr_faster_intel.log:7: Comparing RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK
rt_231_cpld_control_p8_gnu.log:64: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_232_cpld_control_nowave_noaero_p8_gnu.log:63: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_233_cpld_debug_p8_gnu.log:52: Comparing RESTART/ufs.cpld.cpl.r.2021-03-22-32400.nc ............ALT CHECK......NOT OK
rt_234_cpld_control_pdlib_p8_gnu.log:63: Comparing RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc ............ALT CHECK......NOT OK
rt_235_cpld_debug_pdlib_p8_gnu.log:51: Comparing RESTART/ufs.cpld.cpl.r.2021-03-22-32400.nc ............ALT CHECK......NOT OK
rt_236_datm_cdeps_control_cfsr_gnu.log:7: Comparing RESTART/DATM_CFSR.cpl.r.2011-10-02-00000.nc ............ALT CHECK......NOT OK

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

DeniseWorthen and others added 30 commits January 18, 2023 08:44
on-behalf-of @ufs-community <jong.kim@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
update cmeps build to implement check4nans feature using module stored in cdeps repo
@jkbk2004 jkbk2004 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ci Jenkins CI: ORT build/test on docker container labels Oct 3, 2023
@FernandoAndrade-NOAA
Copy link
Collaborator

Jenkins ci log attached, ORTs passed.
ufs-weather-model » ort-docker-pipeline » PR-1894 #1 Console [Jenkins].pdf

@zach1221
Copy link
Collaborator

zach1221 commented Oct 5, 2023

Ok, testing is complete. We can begin the merge process now.

@zach1221 zach1221 merged commit c2d7026 into ufs-community:develop Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Fields exchange module for UFS
5 participants