test_gdasapp_atm_jjob_var failures

[RussTreadon-NOAA]

Clone afe874e g-w with e029bd7 GDASApp. Build GDASApp within g-w on Orion. Execute ctest -R test_gdasapp. 12 out of 54 tests fail. The failed jobs are

        1752 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP (Failed)
        1753 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT (Failed)
        1754 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN (Failed)
        1757 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT (Failed)
        1758 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST (Failed)
        1759 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
        1760 - test_gdasapp_soca_socahybridweights (Failed)
        1761 - test_gdasapp_soca_incr_handler (Failed)
        1762 - test_gdasapp_soca_ens_handler (Failed)
        1771 - test_gdasapp_atm_jjob_var_init (Failed)
        1772 - test_gdasapp_atm_jjob_var_run (Failed)
        1773 - test_gdasapp_atm_jjob_var_final (Failed)

Open this issue to document Failed tests and work toward restoring these tests to Passed.

[RussTreadon-NOAA]

Work for this issue will be done in RussTreadon-NOAA:feature/test_gdasapp

[RussTreadon-NOAA]

Update the following config files in test/atm/global-workflow to restore test_gdasapp_atm_jjob_var functionality

• config.atmanl - make consistent with g-w counterpart with the addition of specifying OBS_LIST and STATICB_TYPE from config.yaml
• config.atmensanl - make consistent with g-w counterpart with the addition of specifying OBS_LIST from config.yaml
• config.yaml - set select base, atmanl, and atmensanl variables to work within test_gdasapp framework

With these changes all test_gdasapp_atm_jjob pass on Orion

Test project /work2/noaa/da/rtreadon/git/global-workflow/test/sorc/gdas.cd/build
    Start 1771: test_gdasapp_atm_jjob_var_init
1/6 Test #1771: test_gdasapp_atm_jjob_var_init ....   Passed   44.50 sec
    Start 1772: test_gdasapp_atm_jjob_var_run
2/6 Test #1772: test_gdasapp_atm_jjob_var_run .....   Passed  106.56 sec
    Start 1773: test_gdasapp_atm_jjob_var_final
3/6 Test #1773: test_gdasapp_atm_jjob_var_final ...   Passed   42.17 sec
    Start 1774: test_gdasapp_atm_jjob_ens_init
4/6 Test #1774: test_gdasapp_atm_jjob_ens_init ....   Passed   44.37 sec
    Start 1775: test_gdasapp_atm_jjob_ens_run
5/6 Test #1775: test_gdasapp_atm_jjob_ens_run .....   Passed  330.30 sec
    Start 1776: test_gdasapp_atm_jjob_ens_final
6/6 Test #1776: test_gdasapp_atm_jjob_ens_final ...   Passed   42.18 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 610.90 sec

Updated config files committed at a73defa.

[RussTreadon-NOAA]

test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP

Run test with -VV option. Job failed with TypeError. The tail end of the traceback is shown below

2024-03-19 20:36:54,388 - INFO     - root        : {'geometry': {'mom6_input_nml': 'mom_input.nml', 'fields metadata': './fields_metadata.yaml'}, 'background': {'read_from_file': 1, 'basename': './INPUT/', 'ocn_filename': 'MOM.res.nc', 'ice_filename': 'cice.res.nc', 'date': '2018-04-15T09:00:00Z', 'state variables': ['cicen', 'hicen', 'hsnon', 'socn', 'tocn', 'uocn', 'vocn', 'ssh']}, 'background error': {'covariance model': 'SABER', 'saber central block': {'saber block name': 'EXPLICIT_DIFFUSION', 'geometry': {'mom6_input_nml': 'mom_input.nml', 'fields metadata': './fields_metadata.yaml'}, 'calibration': {'normalization': {'method': 'randomization', 'iterations': 1000}, 'groups': [{'name': 'vt_ocean', 'vertical': {'as gaussian': True, 'fixed value': 5.0}, 'write': {'filename': 'vt_ocean.nc'}}]}}}}
Traceback (most recent call last):
  File "/work2/noaa/da/rtreadon/git/global-workflow/test/sorc/gdas.cd/scripts/exgdas_global_marine_analysis_prep.py", line 274, in <module>
    ufsda.yamltools.save_check(varconfig.as_dict(), target=var_yaml, app='var')
TypeError: 'dict' object is not callable
+ JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP[1]: postamble JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP 1710880567 1
+ preamble.sh[70]: set +x
End JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP at 20:36:54 with error code 1 (time elapsed: 00:00:47)

[RussTreadon-NOAA]

The test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS are reported in PR #928.

Given this change this issue to focus on test_gdasapp_atm_jjob_var failures.

[RussTreadon-NOAA]

Change name of branch with updates to RussTreadon-NOAA:feature/test_gdasapp_atm_jjob_var