restore ATM local ensemble ctest functionality #1003
Conversation
RussTreadon-NOAA
added
the
orion-GW-RT
emcbot
added
orion-GW-RT-Running
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
orion-GW-RT-Failed
|
The |
|
As such, I think this PR is ready for review, approval, and merger into GDASApp |
|
@DavidNew-NOAA : I see g-w PR #2420. I assume that if I build |
@RussTreadon-NOAA Yes, that's correct for the test_gdasapp_fv3jedi_fv3inc test. I assume that's the case for the test_gdasapp_atm_jjob_var_run, but I'm realizing now that I may have needed to modify those jjob tests in the my GDASApp PR, given that g-w PR #2420 changes the structure and names of two atmanl jobs. I need to investigate. |
|
OK, so JGLOBAL_ATM_ANALYSIS_RUN is now JGLOBAL_ATM_ANALYSIS_VARIATIONAL in g-w branch feature/jediinc2fv3 will break the test_gdasapp_atm_jjob_var_run test. I will need to do a quick bugfix PR into GDASApp develop. Thanks for feedback. |
|
@DavidNew-NOAA , thanks for letting me know. Instead of you opening a new issue to fix ATM variational ctest functionality, I can modify the description of this issue and make the change in my branch. Does this work for you? |
@RussTreadon-NOAA Sure, that would be great, thank you. However, in addition do modifying the run job test, a new test will need to be made for the new job JGLOBAL_ATM_ANALYSIS_FV3_INCREMENT (gdasatmanlfv3inc), which is added in feature/jediinc2fv3. |
|
@DavidNew-NOAA: OK, I see. I jumped before looking. While the changes for adding an new job step are straight forward, I may not get everything in place and tested before I go on leave COB tomorrow. Given this, it's preferable to limit this PR to |
|
Ok, sounds good. |
|
@CoryMartin-NOAA , @guillaumevernieres , or @DavidNew-NOAA : would one of you review these changes and approve so we can merge this fix into GDASApp |
|
Thank you @CoryMartin-NOAA . Merging now. |
|
Hi Russ,
To clarify, do you want me to open this issue and PR since you'll be on
leave?
David
…On Thu, Mar 28, 2024 at 1:47 PM RussTreadon-NOAA ***@***.***> wrote:
@DavidNew-NOAA <https://github.com/DavidNew-NOAA>: OK, I see. I jumped
before looking. While the changes for adding an new job step are straight
forward, I may not get everything in place and tested before I go on leave
COB tomorrow. Given this, it's preferable to limit this PR to
test_atm_jjob_ens and open a new issue & PR to expand test_atm_jjob_var
to with with the new job.
—
Reply to this email directly, view it on GitHub
<#1003 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAAUIHHXGXQYCEMNPR4MWJ3Y2RJTPAVCNFSM6AAAAABFM74UBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVG44DMMBSG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@DavidNew-NOAA : Yes, please open an issue to document the fact that the |
* origin/develop: Use <filesystem> on a non c++17 supported machine (WCOSS ACORN) (#1026) Change generate_com to declare_from_tmpl (#1025) Commenting out more of the marine bufr 2 ioda stuff (#1018) make driver consistent with workflow driver (#1016) Update hashes now that GSI-B is working for EnVar (#1015) Add GitHub CLI to path for CI (#1014) Use _anl rather than _ges dimensions for increments in FV3 increment converter YAML (#1013) Fix inconsistent VIIRS preprocessing test (#1012) remove gdas_ prefix from executable filename in test_gdasapp_fv3jedi_fv3inc (#1010) Bugfix on Broken GHRSST Ioda Converter (#1004) Moved the marine converters to a "safe" place (#1007) restore ATM local ensemble ctest functionality (#1003) Add BUFR2IODA python API converter to prepoceanobs task (#914) Remove sst's from obs proc (#1001) JEDI increment write to cubed sphere history (#983) [End- to End Test code sprint] Add SEVIRI METEOSAT-8 and METEOSAT-11 to end-to-end testing (#766)
g-w
developcommit 47302153 modified howEUPD_CYCis set inconfig.base. This variable is now set in a configuration yaml. This requires a change in howtest_gdasapp_atm_jjob_ensis configured. This PR include the required change.Fixes #1002