Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _anl rather than _ges dimensions for increments in FV3 increment converter YAML #1013

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

DavidNew-NOAA
Copy link
Collaborator

npx_ges should be npx_anl for the JEDI and FV3 increments. Same for npy and npz. See NOAA-EMC/global-workflow#2420 (comment)

@DavidNew-NOAA DavidNew-NOAA marked this pull request as ready for review March 29, 2024 20:29
@CoryMartin-NOAA
Copy link
Contributor

@DavidNew-NOAA where will you account for the interpolation of the increment when it is added to the background?

In current GDAS operations, the analysis resolution (i.e. that which the increment is computed on) is the ensemble resolution which is half the background resolution. That is why the .ensres files exist. The benefit of JEDI writing the increment on the input resolution is that you can just do analysis = guess + increment, but if you write out the native increment, you have to interpolate it to the guess resolution first.

Does that make sense?

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my late Friday ramblings

@CoryMartin-NOAA CoryMartin-NOAA merged commit b0ef0ce into develop Mar 29, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the bugfix/fv3inc_anl_dim branch March 29, 2024 20:44
danholdaway added a commit that referenced this pull request Apr 8, 2024
* origin/develop:
  Use <filesystem> on a non c++17 supported machine (WCOSS ACORN) (#1026)
  Change generate_com to declare_from_tmpl (#1025)
  Commenting out more of the marine bufr 2 ioda stuff (#1018)
  make driver consistent with workflow driver (#1016)
  Update hashes now that GSI-B is working for EnVar (#1015)
  Add GitHub CLI to path for CI (#1014)
  Use _anl rather than _ges dimensions for increments in FV3 increment converter YAML (#1013)
  Fix inconsistent VIIRS preprocessing test (#1012)
  remove gdas_ prefix from executable filename in test_gdasapp_fv3jedi_fv3inc (#1010)
  Bugfix on Broken GHRSST Ioda Converter (#1004)
  Moved the marine converters to a "safe" place (#1007)
  restore ATM local ensemble ctest functionality (#1003)
  Add BUFR2IODA python API converter to prepoceanobs task (#914)
  Remove sst's from obs proc (#1001)
  JEDI increment write to cubed sphere history (#983)
  [End- to End Test code sprint] Add SEVIRI METEOSAT-8 and METEOSAT-11 to end-to-end testing (#766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants