Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save basic stats in csv at each cycle #1040

Merged
merged 7 commits into from
Apr 15, 2024
Merged

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Apr 12, 2024

Work done

Computes basic stats (count, bias and rmse of omb's and oma's) for different ocean basins, this assumes the obs were flagged with the ocean mask from RECCAP2_region_masks_all_v20221025.nc.

  • The stats are computed within the post ocean analysis jjob. Failure of this job will only results in a warning.
  • I provided a simple plotting script that will accept multiple experiments as arguments and plot time series. Not sure if we want this in the vrfy job

Work left to do

We're not flagging the obs currently, so that code will do nothing until we update the prep ocean obs yaml to point to RECCAP2_region_masks_all_v20221025.nc (it's been copied to the soca fix dir on hera and orion). To have the obs flagged in develop will require the ioda converters to not fail if the RECCAP2_region_masks_all_v20221025 isn't found.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 12, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 12, 2024
@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Apr 12 16:06:15 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Apr 12 17:16:44 CDT 2024
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1040/global-workflow/sorc/log.build

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 12, 2024
@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Apr 12 21:13:55 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Apr 12 22:05:26 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Apr 12 22:33:55 UTC 2024
Tests: 92% tests passed, 4 tests failed out of 53
	1742 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1776 - test_gdasapp_atm_jjob_var_run (Failed)
	1777 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1040/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 12, 2024
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think things will need cleaned up for "ops" but fine for current purpose.

@guillaumevernieres guillaumevernieres merged commit 420459c into develop Apr 15, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/ts-stats branch April 15, 2024 21:35
danholdaway added a commit that referenced this pull request Apr 17, 2024
* upstream/develop:
  Get SOCA vrfy job working on Hera again (#1045)
  Get test data from a staged location on supported HPC Part Deux (#1052)
  Prepare observations for snow DA updates to the ensemble members (#998)
  Save basic stats in csv at each cycle (#1040)
  Fix bug for datetime in GHRSST Ioda Converter (#1027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants