Prepare observations for snow DA updates to the ensemble members #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
There was a problem hiding this comment.
Do you have a draft, corresponding workflow PR? I am not particularly thrilled about these additional variable names and would prefer to come up with a way that is more consistent with other observation types.
EDIT: Never mind, I see you have it linked above. I will comment there.
…/GDASApp into feature/prepsnowobs_ens
CoryMartin-NOAA
approved these changes
Apr 16, 2024
danholdaway
added a commit
that referenced
this pull request
Apr 17, 2024
* upstream/develop: Get SOCA vrfy job working on Hera again (#1045) Get test data from a staged location on supported HPC Part Deux (#1052) Prepare observations for snow DA updates to the ensemble members (#998) Save basic stats in csv at each cycle (#1040) Fix bug for datetime in GHRSST Ioda Converter (#1027)
|
@jiaruidong2017 I'm going to revert this PR as I think it is holding up other workflow PRs. We can re-merge it when the workflow is ready... |
CoryMartin-NOAA
added a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates several configures to prepare observations for snow DA updates to the ensemble members. Because the snow observations are fetched from the COM_OBS in the gdas deterministic analysis and are saved into the COM_OBS in the enkfgdas analysis for the enkfgdas run, we have to define two different COM_OBS directories (COMIN_OBS vs COMOUT_OBS) and two obs basename heads (OPREFIX_IN vs OPREFIX_OUT) to identify the enkf analysis from the gdas deterministic analysis.
This PR will contribute to NOAA-EMC/global-workflow#2416.