Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change YAML and add jjob CTest for new "atmensanlfv3inc" job in Global Workflow #1104

Merged
merged 11 commits into from
May 13, 2024

Conversation

DavidNew-NOAA
Copy link
Collaborator

@DavidNew-NOAA DavidNew-NOAA commented May 10, 2024

This PR is a companion to Global Workflow PR #2593, which adds the "atmensanlfv3inc" job to Global Workflow. That job converts the JEDI ensemble increments into FV3 readable increments. This JCB-GDAS companion PR is #3, which updates the input YAMLs for the FV3 increment converter

This PR does two things:

  1. It adds a jjob CTest to GDASApp to test this new job.
  2. It modifies the LETKF input YAML to write out cubed-sphere history increments, rather than Gaussian increments, so the FV3 increment converter can read the resulting increment off the native grid and then itself write out a Gaussian increment.

@DavidNew-NOAA DavidNew-NOAA changed the title Feature/atmensanlfv3inc Add jjob CTest for new "atmensanlfv3inc" job in Global Workflow May 10, 2024
@DavidNew-NOAA DavidNew-NOAA marked this pull request as ready for review May 10, 2024 14:13
@DavidNew-NOAA DavidNew-NOAA changed the title Add jjob CTest for new "atmensanlfv3inc" job in Global Workflow Change YAML and add jjob CTest for new "atmensanlfv3inc" job in Global Workflow May 10, 2024
@CoryMartin-NOAA CoryMartin-NOAA merged commit a1c5cca into develop May 13, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/atmensanlfv3inc branch May 13, 2024 14:58
@RussTreadon-NOAA
Copy link
Contributor

Orion test
Install GDASApp feature/atmensanlfv3inc inside g-w DavidNew-NOAA:feature/atmensanlfv3inc. Execute ctest -R test_gdasapp. 5 out of 46 tests fail. The failed tests are

        1762 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST (Failed)
        1778 - test_gdasapp_atm_jjob_ens_init (Failed)
        1779 - test_gdasapp_atm_jjob_ens_run (Failed)
        1780 - test_gdasapp_atm_jjob_ens_inc (Failed)
        1781 - test_gdasapp_atm_jjob_ens_final (Failed)

I did not check test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST Job test_gdasapp_atm_jjob_ens_init failed with

jinja2.exceptions.TemplateNotFound: output_ensemble_increments_cubed_sphere.yaml.j2

Does this PR require changes in jcb-algorithms or jcb-gdas?

@RussTreadon-NOAA
Copy link
Contributor

Oops, I see this PR was just merged into develop. Apologies that I didn't get to this until today.

@CoryMartin-NOAA
Copy link
Contributor

I think it needs changes in global workflow, @RussTreadon-NOAA. @DavidNew-NOAA has a PR open there that this depends on. NOAA-EMC/global-workflow#2592

@CoryMartin-NOAA
Copy link
Contributor

However, I see we need to update the hash of jcb-gdas, so I need to revert this. MY bad for hitting the trigger too quickly.

@CoryMartin-NOAA
Copy link
Contributor

I'll open a quick PR to update the JCB hash

@DavidNew-NOAA
Copy link
Collaborator Author

Thanks

@RussTreadon-NOAA
Copy link
Contributor

Yes, we need the jcb-gdas hash. It contains the missing template.

CoryMartin-NOAA added a commit that referenced this pull request May 13, 2024
@RussTreadon-NOAA
Copy link
Contributor

Closing this thread.

Update Orion working copy of gdas.cd to develop at 6742ec6. This is the commit which brought in GDASApp PR #1108. This PR updated the jcb-gdas hash. Rerun ctest -R test_gdasapp_atm_jjob_ens. All four jobs pass.

Test project /work2/noaa/da/rtreadon/git/global-workflow/fv3inc/sorc/gdas.cd/build
    Start 1778: test_gdasapp_atm_jjob_ens_init
1/4 Test #1778: test_gdasapp_atm_jjob_ens_init ....   Passed   43.75 sec
    Start 1779: test_gdasapp_atm_jjob_ens_run
2/4 Test #1779: test_gdasapp_atm_jjob_ens_run .....   Passed  490.27 sec
    Start 1780: test_gdasapp_atm_jjob_ens_inc
3/4 Test #1780: test_gdasapp_atm_jjob_ens_inc .....   Passed  138.18 sec
    Start 1781: test_gdasapp_atm_jjob_ens_final
4/4 Test #1781: test_gdasapp_atm_jjob_ens_final ...   Passed   42.14 sec

100% tests passed, 0 tests failed out of 4

Total Test time (real) = 714.82 sec

WalterKolczynski-NOAA pushed a commit to NOAA-EMC/global-workflow that referenced this pull request May 28, 2024
This PR creates the atmensanlfv3inc job, the ensemble version of
atmanlfv3inc, created in GW PR #2420. Its GDASApp companion PR is
#[1104](NOAA-EMC/GDASApp#1104), and its JCB-GDAS
companion PR is #[3](NOAA-EMC/jcb-gdas#3).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants