Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jcb-gdas hash to bring in satwnd yaml changes #1128

Merged
merged 2 commits into from
May 24, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented May 24, 2024

This PR updates the jcb-gdas hash in parm to bring in satwnd yaml updates consistent with the satwnd bufr2ioda changes from PR #1119.

Resolves #1127
Dependency: jcb-gdas PR #13

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this May 24, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

This PR will be marked Ready for review after

  1. jcb-gdas PR #13 is merged into jcb-gdas develop
  2. The jcb-gdas hash in GDASApp branch bugfix/satwnd_jcb-gdas is updated to point at the new head of the jcb-gdas develop.

@RussTreadon-NOAA
Copy link
Contributor Author

First attempt to run test_gdasapp from bugfix/satwnd_jcb-gdas build inside g-w develop at 7d2c539 (the current head) yielded

94% tests passed, 3 tests failed out of 47

Label Time Summary:
gdas-utils    =  14.30 sec*proc (9 tests)
script        =  14.30 sec*proc (9 tests)

Total Test time (real) = 1260.15 sec

The following tests FAILED:
        1792 - test_gdasapp_atm_jjob_ens_run (Failed)
        1793 - test_gdasapp_atm_jjob_ens_inc (Failed)
        1794 - test_gdasapp_atm_jjob_ens_final (Failed)

The test_gdasapp_atm_jjob_ens_run failure is due to

1792: + sbatch --nodes=1 --ntasks=36 --account=da-cpu --qos=batch --time=00:30:00 --export=ALL --wait /work2/noaa/da/rtreadon/git/global-workflow/test/jobs/JGLOBAL_ATMENS_ANALYSIS_LETKF
1792: sbatch: error: Unable to open file /work2/noaa/da/rtreadon/git/global-workflow/test/jobs/JGLOBAL_ATMENS_ANALYSIS_LETKF
1/1 Test #1792: test_gdasapp_atm_jjob_ens_run ....***Failed    0.10 sec

GDASApp PR #1104 updated the name of the g-w name of the lgetkf run job. JGLOBAL_ATMENS_ANALYSIS_RUN was replaced with JGLOBAL_ATMENS_ANALYSIS_LETKF. g-w PR #2592 contains the change in the job name. Unfortunately, g-w PR #2592 remains in review. Hence the above failure due to inconsistent names between GDASApp and g-w for the ensemble run job.

Will try again by cloning g-w PR #2592 branch along with bugfix/satwnd_jcb-gdas for sorc/gdas.cd.

@RussTreadon-NOAA
Copy link
Contributor Author

Build bugfix/satwnd_jcb-gdas inside working copy of DavidNew-NOAA:feature/atmensanlfv3inc (the forked branch for g-w PR #2592). This time all 47 test_gdasapp pass

Test project /work2/noaa/da/rtreadon/git/global-workflow/fv3inc/sorc/gdas.cd/build
      Start 1400: test_gdasapp_util_coding_norms
 1/47 Test #1400: test_gdasapp_util_coding_norms ........................   Passed    3.35 sec
      Start 1401: test_gdasapp_util_ioda_example
 2/47 Test #1401: test_gdasapp_util_ioda_example ........................   Passed    4.31 sec
      Start 1402: test_gdasapp_util_prepdata
 3/47 Test #1402: test_gdasapp_util_prepdata ............................   Passed    2.62 sec
      Start 1403: test_gdasapp_util_rads2ioda
 4/47 Test #1403: test_gdasapp_util_rads2ioda ...........................   Passed    0.14 sec
      Start 1404: test_gdasapp_util_ghrsst2ioda
 5/47 Test #1404: test_gdasapp_util_ghrsst2ioda .........................   Passed    0.12 sec
      Start 1405: test_gdasapp_util_smap2ioda
 6/47 Test #1405: test_gdasapp_util_smap2ioda ...........................   Passed    0.12 sec
      Start 1406: test_gdasapp_util_smos2ioda
 7/47 Test #1406: test_gdasapp_util_smos2ioda ...........................   Passed    0.12 sec
      Start 1407: test_gdasapp_util_viirsaod2ioda
 8/47 Test #1407: test_gdasapp_util_viirsaod2ioda .......................   Passed    0.13 sec
      Start 1408: test_gdasapp_util_icecamsr2ioda
 9/47 Test #1408: test_gdasapp_util_icecamsr2ioda .......................   Passed    0.12 sec
      Start 1746: test_gdasapp_check_python_norms
10/47 Test #1746: test_gdasapp_check_python_norms .......................   Passed    2.91 sec
      Start 1747: test_gdasapp_check_yaml_keys
11/47 Test #1747: test_gdasapp_check_yaml_keys ..........................   Passed    1.54 sec
      Start 1748: test_gdasapp_jedi_increment_to_fv3
12/47 Test #1748: test_gdasapp_jedi_increment_to_fv3 ....................   Passed   11.25 sec
      Start 1749: test_gdasapp_setup_cycled_exp
13/47 Test #1749: test_gdasapp_setup_cycled_exp .........................   Passed    2.01 sec
      Start 1750: test_gdasapp_fv3jedi_fv3inc
14/47 Test #1750: test_gdasapp_fv3jedi_fv3inc ...........................   Passed   35.86 sec
      Start 1751: test_gdasapp_soca_nsst_increment_to_mom6
15/47 Test #1751: test_gdasapp_soca_nsst_increment_to_mom6 ..............   Passed   34.85 sec
      Start 1752: test_gdasapp_soca_prep
16/47 Test #1752: test_gdasapp_soca_prep ................................   Passed    4.98 sec
      Start 1753: test_gdasapp_soca_run_clean
17/47 Test #1753: test_gdasapp_soca_run_clean ...........................   Passed    0.02 sec
      Start 1754: test_gdasapp_soca_setup_obsprep
18/47 Test #1754: test_gdasapp_soca_setup_obsprep .......................   Passed    9.39 sec
      Start 1755: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS
19/47 Test #1755: test_gdasapp_soca_JGLOBAL_PREP_OCEAN_OBS ..............   Passed   42.73 sec
      Start 1756: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
20/47 Test #1756: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP ....   Passed   42.20 sec
      Start 1757: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT
21/47 Test #1757: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT ....   Passed  138.22 sec
      Start 1758: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
22/47 Test #1758: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN .....   Passed   42.37 sec
      Start 1759: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN
23/47 Test #1759: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN ....   Passed   42.19 sec
      Start 1760: test_gdasapp_soca_copy_scratch
24/47 Test #1760: test_gdasapp_soca_copy_scratch ........................   Passed    2.43 sec
      Start 1761: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
25/47 Test #1761: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT ...   Passed   42.19 sec
      Start 1762: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
26/47 Test #1762: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST ....   Passed   42.18 sec
      Start 1763: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY
27/47 Test #1763: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY ....   Passed  234.25 sec
      Start 1764: test_gdasapp_soca_socahybridweights
28/47 Test #1764: test_gdasapp_soca_socahybridweights ...................   Passed   42.19 sec
      Start 1765: test_gdasapp_soca_incr_handler
29/47 Test #1765: test_gdasapp_soca_incr_handler ........................   Passed   10.16 sec
      Start 1766: test_gdasapp_soca_ens_handler
30/47 Test #1766: test_gdasapp_soca_ens_handler .........................   Passed   10.15 sec
      Start 1767: test_gdasapp_snow_create_ens
31/47 Test #1767: test_gdasapp_snow_create_ens ..........................   Passed    1.04 sec
      Start 1768: test_gdasapp_snow_imsproc
32/47 Test #1768: test_gdasapp_snow_imsproc .............................   Passed    5.26 sec
      Start 1769: test_gdasapp_snow_apply_jediincr
33/47 Test #1769: test_gdasapp_snow_apply_jediincr ......................   Passed    3.88 sec
      Start 1770: test_gdasapp_snow_letkfoi_snowda
34/47 Test #1770: test_gdasapp_snow_letkfoi_snowda ......................   Passed   14.17 sec
      Start 1771: test_gdasapp_convert_bufr_adpsfc_snow
35/47 Test #1771: test_gdasapp_convert_bufr_adpsfc_snow .................   Passed    3.09 sec
      Start 1784: test_gdasapp_convert_bufr_adpsfc
36/47 Test #1784: test_gdasapp_convert_bufr_adpsfc ......................   Passed    3.84 sec
      Start 1785: test_gdasapp_convert_gsi_satbias
37/47 Test #1785: test_gdasapp_convert_gsi_satbias ......................   Passed    1.77 sec
      Start 1786: test_gdasapp_setup_atm_cycled_exp
38/47 Test #1786: test_gdasapp_setup_atm_cycled_exp .....................   Passed    0.58 sec
      Start 1787: test_gdasapp_atm_jjob_var_init
39/47 Test #1787: test_gdasapp_atm_jjob_var_init ........................   Passed  267.98 sec
      Start 1788: test_gdasapp_atm_jjob_var_run
40/47 Test #1788: test_gdasapp_atm_jjob_var_run .........................   Passed  106.74 sec
      Start 1789: test_gdasapp_atm_jjob_var_inc
41/47 Test #1789: test_gdasapp_atm_jjob_var_inc .........................   Passed  106.14 sec
      Start 1790: test_gdasapp_atm_jjob_var_final
42/47 Test #1790: test_gdasapp_atm_jjob_var_final .......................   Passed   42.14 sec
      Start 1791: test_gdasapp_atm_jjob_ens_init
43/47 Test #1791: test_gdasapp_atm_jjob_ens_init ........................   Passed   43.76 sec
      Start 1792: test_gdasapp_atm_jjob_ens_run
44/47 Test #1792: test_gdasapp_atm_jjob_ens_run .........................   Passed  458.25 sec
      Start 1793: test_gdasapp_atm_jjob_ens_inc
45/47 Test #1793: test_gdasapp_atm_jjob_ens_inc .........................   Passed  170.17 sec
      Start 1794: test_gdasapp_atm_jjob_ens_final
46/47 Test #1794: test_gdasapp_atm_jjob_ens_final .......................   Passed   74.14 sec
      Start 1795: test_gdasapp_aero_gen_3dvar_yaml
47/47 Test #1795: test_gdasapp_aero_gen_3dvar_yaml ......................   Passed    0.25 sec

100% tests passed, 0 tests failed out of 47

Label Time Summary:
gdas-utils    =  11.04 sec*proc (9 tests)
script        =  11.04 sec*proc (9 tests)

Total Test time (real) = 2108.85 sec

Enable C96C48_ufs_hybatmDA on Orion. Run JEDI ATM CI. All jobs successfully run to completion

Orion-login-2:/work2/noaa/stmp/rtreadon/EXPDIR/prtest$ rocotostat -d prtest.db -w prtest.xml -c all -s
   CYCLE         STATE           ACTIVATED              DEACTIVATED
202402231800        Done    May 24 2024 14:02:12    May 24 2024 14:25:25
202402240000        Done    May 24 2024 14:02:12    May 24 2024 16:21:42

@RussTreadon-NOAA
Copy link
Contributor Author

Once jcb-gdas PR #13 is approved and merged into jcb-gdas develop, the parm/jcb-gdas hash in bugfix/satwnd_jcb-gdas will be updated. This PR will be marked Ready for review after the parm/jcb-gdas hash is updated.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review May 24, 2024 17:54
Copy link
Collaborator

@BrettHoover-NOAA BrettHoover-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @BrettHoover-NOAA !

@RussTreadon-NOAA RussTreadon-NOAA merged commit 9e70fc6 into develop May 24, 2024
5 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the bugfix/satwnd_jcb-gdas branch May 24, 2024 18:48
danholdaway added a commit that referenced this pull request Jun 4, 2024
* origin/develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
* develop:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
  Update hera.intel.lua (#1109)
danholdaway added a commit that referenced this pull request Jun 4, 2024
 into feature/rename_atm

* 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp:
  Update wcoss2.intel.lua (#1142)
  Add yaml file for prepobsaero task (#1141)
  Diffusion parameter yaml template (#1140)
  Adjust absolute float tolerance for variational and ensemble DA jjob tests (#1136)
  Insitu temp and salt (#1135)
  Adds letkf.yaml(.j2)  (#1134)
  Add optional testing block to 3dvar and lgetkf input YAMLs for jjobs (#1129)
  updates to build and run some ctests on WCOSS2 (#1122)
  Addin a GFSv17 ctest (#1130)
  Feature/rtofs in situ (#1110)
  update jcb-gdas hash to bring in satwnd yaml changes (#1128)
  Optionally run specified rocoto task as part of the ctests  (#1121)
  Add build capability to Gaea-C5 (#1101)
  Python Converter and Json for the ADPUPA BUFR DUMP (#1115)
  Revert "Fix ice water FV3 increment variable name and add a few more … (#1125)
  Satwnd and variable name-convention updates for jcb implementation in GDASApp (#1119)
  Add inverse distance weighting option to superob function (#1116)
  Resume the Marine Vrfy Task on ctests (#1107)
  Replicate the creation of the gw-ci cycling test (#1114)
  Added YAML, JSON, python files for assimilating LEOGEO satwinds (#1099)
  Add an OOPS-based application to recenter snow analysis (#1102)
  Fix ice water FV3 increment variable name and add a few more (#1112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jcb-gdas hash for satwnd changes
2 participants