Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds staging jinja/yaml file for letkf task #1137

Merged
merged 16 commits into from
Jun 6, 2024
Merged

Adds staging jinja/yaml file for letkf task #1137

merged 16 commits into from
Jun 6, 2024

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

Adds staging jinja/yaml file for letkf task, for staging files to DATA

Towards #1091

guillaumevernieres
guillaumevernieres reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, but I'm no expert.
See minor comments

test/soca/gw/CMakeLists.txt Outdated Show resolved Hide resolved
test/soca/gw/run_gdas_apps.yaml.test Outdated Show resolved Hide resolved
test/soca/gw/run_jjobs.yaml.test Outdated Show resolved Hide resolved
CoryMartin-NOAA
CoryMartin-NOAA reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments otherwise this looks great

parm/soca/letkf/letkf_stage.yaml.j2 Outdated Show resolved Hide resolved
parm/soca/letkf/letkf_stage.yaml.j2 Outdated Show resolved Hide resolved
parm/soca/letkf/letkf_stage.yaml.j2 Outdated Show resolved Hide resolved
parm/soca/letkf/letkf_stage.yaml.j2 Outdated Show resolved Hide resolved
@AndrewEichmann-NOAA
Copy link
Collaborator Author

I set the background files from f006 to f009 because that is what is currently set up in the ctests. Relatedly, one option would be to define the files as {{ RUN }}.ice.t{{ gcyc }}z.inst.f006.nc in the config file and have the jinja files point to that. Waddaya think?

CoryMartin-NOAA
CoryMartin-NOAA reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one clarification/question, otherwise I'm happy

parm/soca/letkf/letkf_stage.yaml.j2 Outdated Show resolved Hide resolved
@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review June 6, 2024 13:44
@CoryMartin-NOAA CoryMartin-NOAA merged commit e9eebbb into develop Jun 6, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/ocn-lektf-imp branch June 6, 2024 15:52
danholdaway added a commit that referenced this pull request Jun 6, 2024
@danholdaway
Merge branch 'develop' into feature/move_jcb
0cda73b 
* develop:
  Changes name of rossrad file for letkf (#1151)
  Adds staging jinja/yaml file for letkf task (#1137)
danholdaway added a commit that referenced this pull request Jun 13, 2024
@danholdaway
Merge branch 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp
fe5169c 
 into feature/rename_atm

* 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp:
  Feature/rtofs in situ (#1138)
  Updates to aerosol yaml templates (#1158)
  Use standard config files for jjob test and give output files better names (#1156)
  Temporary removal of soca_vrfy task (#1157)
  Fix keyword for float tolerances in jjob tests (#1154)
  Create template YAML for n21 aerosol obs and update obs QC in YAMLs (#1152)
  Changes name of rossrad file for letkf (#1151)
  Adds staging jinja/yaml file for letkf task (#1137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndrewEichmann-NOAA @CoryMartin-NOAA @guillaumevernieres