Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rtofs in situ #1138

Merged
merged 23 commits into from
Jun 10, 2024
Merged

Feature/rtofs in situ #1138

merged 23 commits into from
Jun 10, 2024

Conversation

givelberg
Copy link
Collaborator

Created 2 converters with corresponding tests, for temperature and salinity.
2 different files are created.
For temperature the file includes
tmp, tmp_err, lon, lat, depth
and metadata sal_typ and flg
Similarly, for salinity..

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @givelberg . A few minor comments related to the ctest. We'll figure out where to keep these RTOFS binaries next week.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jun 10, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jun 10, 2024
@emcbot
Copy link

emcbot commented Jun 10, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Sun Jun  9 20:50:24 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Sun Jun  9 21:37:04 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Sun Jun  9 22:00:29 CDT 2024
Tests: 96% tests passed, 2 tests failed out of 48
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1138/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jun 10, 2024
@emcbot
Copy link

emcbot commented Jun 10, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Jun 10 14:30:53 UTC 2024 on hfe05
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Mon Jun 10 14:50:20 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1138/global-workflow/sorc/log.build

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jun 10, 2024
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. I didn't see any other HEAD or residuals from your last merge, but you might want to double check.
Also, you need to merge develop into your branch again.

utils/test/CMakeLists.txt Outdated Show resolved Hide resolved
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Jun 10, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jun 10, 2024
@emcbot
Copy link

emcbot commented Jun 10, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Jun 10 12:15:51 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jun 10 13:00:43 CDT 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jun 10 13:27:26 CDT 2024
Tests: 100% tests passed, 0 tests failed out of 48

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jun 10, 2024
@emcbot
Copy link

emcbot commented Jun 10, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Jun 10 17:15:41 UTC 2024 on hfe12
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jun 10 18:04:46 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jun 10 18:31:28 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 48

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jun 10, 2024
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @givelberg !

@guillaumevernieres guillaumevernieres merged commit 9645e0d into develop Jun 10, 2024
17 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/RTOFSInSitu branch June 10, 2024 18:41
@RussTreadon-NOAA
Copy link
Contributor

This PR changed the hash for the following repos in sorc/: fv3, gsibec, gsw, land-imsproc, land-jediincr. The modified hashes in this PR are newer than what was previously in GDASApp sorc/ except for gsibec.

This PR changed gsibec to `gsibec @ e6e1944. This commit is dated June 26, 2203.

Before this PR was merged into develop, we were using gsibec @ c8ac58d. This commit is dated March 8, 2024. This gsibec hash is tags/1.2.1.

g-w C96C48_ufs_hybatmDA CI using the current head of GDASApp (7f4c2fc) failed when running the gfs and gdas atmanlvar. Both job aborted with the error message

 0: Exception: gsi static covariance does not exist in saber::SaberCentralBlockFactory
 0: Exception: oops::Variational<FV3JEDI, UFO and IODA observations> terminating...
 0: Exception: level: 0
 0: gsi static covariance does not exist in saber::SaberCentralBlockFactory
 0: OOPS Ending   2024-06-11 16:39:22 (UTC+0000)

This reason for this failure is that the gsibec hash GDASApp currently points at is out of date with other repository snapshots in sorc/. As a test gsibec was updated to gsibec tags/1.2.1 and GDASApp rebuilt. Reruns of the g-w CI gfs and gdas atmanlvar jobs were successful.

We need to revert sorc/gsibec back to gsibec tags/1.2.1 (hash c8ac58d)

@guillaumevernieres
Copy link
Contributor

Ouch, sorry about this @RussTreadon-NOAA . Not quite sure how I missed this but I did ...

danholdaway added a commit that referenced this pull request Jun 13, 2024
 into feature/rename_atm

* 'feature/rename_atm' of https://github.com/NOAA-EMC/GDASApp:
  Feature/rtofs in situ (#1138)
  Updates to aerosol yaml templates (#1158)
  Use standard config files for jjob test and give output files better names (#1156)
  Temporary removal of soca_vrfy task (#1157)
  Fix keyword for float tolerances in jjob tests (#1154)
  Create template YAML for n21 aerosol obs and update obs QC in YAMLs (#1152)
  Changes name of rossrad file for letkf (#1151)
  Adds staging jinja/yaml file for letkf task (#1137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants