Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of the marine B-matrix job #1211

Merged
merged 27 commits into from
Jul 22, 2024
Merged

Refactoring of the marine B-matrix job #1211

merged 27 commits into from
Jul 22, 2024

Conversation

guillaumevernieres
Copy link
Contributor

Description

It needs more cleanup, and the norms are failing, so it's a draft for now.
This PR moves most of the B-matrix generation into the g-w. It introduces a new jjob, JGLOBAL_MARINE_BMAT, that replaces the old one that I have yet to remove.

What is not addressed yet

  • I need to revisit the post job/script
  • We lost the functionality to point to offline ensemble members, for now ...

Companion PR

global-workflow companion PR

Issues addressed

@guillaumevernieres guillaumevernieres mentioned this pull request Jul 5, 2024
Merged
17 tasks
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera hera-GW-RT-tier2 1/2 cycle forecast + DA tests labels Jul 9, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 9, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 10, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 10, 2024
@emcbot
Copy link

emcbot commented Jul 10, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Jul 10 00:38:49 UTC 2024 on hfe03
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jul 10 01:20:11 UTC 2024
---------------------------------------------------
Tier-2 Testing: Activated
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jul 10 01:26:10 UTC 2024
Tests:

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 10, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Jul 10, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 10, 2024
@emcbot
Copy link

emcbot commented Jul 10, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Jul 10 12:40:22 UTC 2024 on hfe12
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jul 10 13:24:20 UTC 2024
---------------------------------------------------
Tier-2 Testing: Activated
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jul 10 13:30:08 UTC 2024
Tests:

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jul 22, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 22, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 22, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 22, 2024
@emcbot
Copy link

emcbot commented Jul 22, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Jul 22 13:52:52 UTC 2024 on hfe03
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jul 22 13:53:25 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jul 22 13:53:27 UTC 2024
Tests:

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 22, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Jul 22, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 22, 2024
@emcbot
Copy link

emcbot commented Jul 22, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Jul 22 14:13:56 UTC 2024 on hfe03
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jul 22 14:57:23 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Jul 22 15:21:15 UTC 2024
Tests: 98% tests passed, 1 tests failed out of 46
	1892 - test_gdasapp_soca_ens_handler (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1211/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 22, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Jul 22, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 22, 2024
@emcbot
Copy link

emcbot commented Jul 22, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Jul 22 16:03:19 UTC 2024 on hfe03
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jul 22 16:49:06 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jul 22 17:34:12 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 43

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 22, 2024
@guillaumevernieres guillaumevernieres changed the title Refactoring of the marine B-matrix job DO NOT MERGE Refactoring of the marine B-matrix job Jul 22, 2024
apchoiCMD
apchoiCMD approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@apchoiCMD apchoiCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me~

@guillaumevernieres guillaumevernieres merged commit 52f41a2 into develop Jul 22, 2024
11 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/marine-det_gv branch July 22, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apchoiCMD apchoiCMD apchoiCMD approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

@JohnSteffen-NOAA JohnSteffen-NOAA Awaiting requested review from JohnSteffen-NOAA

@KatherineLukens-NOAA KatherineLukens-NOAA Awaiting requested review from KatherineLukens-NOAA

@CoryMartin-NOAA CoryMartin-NOAA Awaiting requested review from CoryMartin-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
4 participants
@guillaumevernieres @emcbot @CoryMartin-NOAA @apchoiCMD