-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move fieldmetadata to inside version control rather than glopara fix #537
Conversation
A companion PR after this one will need to be made to global-workflow to update to this hash + modify scripts to look in the new location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
Automated Global-Workflow GDASApp Testing Results:
|
Automated Global-Workflow GDASApp Testing Results:
|
befb664
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern is that all the field meta data were merged into a single file: fv3jedi_fieldmetadata_restart.yaml
. Once there is any change to the meta data from fv3-jedi, how does GDASApp make the updates?
@jiaruidong2017 we just edit the file that I've added here. Not sure I understand the concern (unless I'm missing something) |
@CoryMartin-NOAA What I mean is, do we have a tool which can monitor the changes from |
@jiaruidong2017 I think we want to know when this changes though, not anything automatic. Because this file contains the information on how to read the model state into JEDI. If anything changes here, we would need the model forecasts to change appropriately. We have the tests so that we know if it starts failing that something changed. |
@CoryMartin-NOAA Okay, I understand what you mean |
Tests will fail until the workflow is updated. I have tested this manually on Hera and all tests pass:
This will need to be approved and merged before the workflow tests will pass, which will require a global-workflow PR, which will be a bit of a chicken/egg problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
I think out of convenience before, the glopara/fix/gdas directories contain several text files that do not need to be maintained by the glopara group, and can instead store them in GDASApp or global-workflow.
This PR is the first step towards that, by moving the FV3-JEDI IO fieldmetadata files into GDASApp. Subsequent work will need to determine if things like FV3 diag tables can be shared between FV3-JEDI and the UFS.