Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug for dateTime in IcecAmsr2Ioda.h #756

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

apchoiCMD
Copy link
Collaborator

Description

  • Implemented an additional trim function to ensure that the Obs.Values align with their respective dTime entries
  • Minor changes within for loop and removed unnecessary function
  • Only applied to amsr2_icec

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Nov 20, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Nov 20, 2023
@emcbot
Copy link

emcbot commented Nov 20, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Nov 20 13:31:25 CST 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Nov 20 14:23:07 CST 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Nov 20 14:41:05 CST 2023
Tests: 85% tests passed, 8 tests failed out of 53
	1666 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT (Failed)
	1667 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN (Failed)
	1669 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT (Failed)
	1670 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST (Failed)
	1671 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1673 - test_gdasapp_soca_socahybridweights (Failed)
	1674 - test_gdasapp_soca_incr_handler (Failed)
	1675 - test_gdasapp_soca_ens_handler (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/756/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Nov 20, 2023
@guillaumevernieres
Copy link
Contributor

I probably should have looked a bit more carefully at G-W #2077. The CI is failing for reasons unrelated to your work @apchoiCMD . I'll wait for Hera to be done before merging.

@emcbot
Copy link

emcbot commented Nov 20, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Nov 20 19:32:20 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Nov 20 20:19:22 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Nov 20 21:10:44 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 53

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Nov 20, 2023
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guillaumevernieres guillaumevernieres merged commit 4f089c4 into develop Nov 20, 2023
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/ioda-stdvec-rads branch November 21, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants