Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates detect_machines.sh to be consistent with UFSWM #890

Merged

Conversation

HenryRWinterbottom
Copy link
Contributor

This PR addresses issue #889. The following is accomplished:

  • The GDASApp ush/detect_machine.sh is replaced by the UFS weather-model tests/detect_machine.sh prepared by @BrianCurtis-NOAA;
  • The version of rocoto has been updated from 1.3.3 to 1.3.6 to allow the build system to complete successfully.

This PR does not modify any applications with the GDASApp, only the determination of the respective host. No CI/CD or regression testing should be required.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@RussTreadon-NOAA
Copy link
Contributor

@guillaumevernieres and @CoryMartin-NOAA : This PR contains a critical change to the GDAS hera modulefile. rocototo/1.3.3 is no longer accessible.

Hera(hfe05):~$ ls -l /apps/rocoto/
total 64
drwxr-xr-x 10 role.apps apps 2048 Jan 29 14:04 1.3.6
lrwxrwxrwx  1 role.apps apps    5 Jan 29 14:10 default -> 1.3.6

We need to move to rocoto/1.3.6. on Hera This PR makes this change. Thank you @HenryWinterbottom-NOAA !

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HenryWinterbottom-NOAA .

@RussTreadon-NOAA
Copy link
Contributor

Clone HenryWinterbottom-NOAA:feature/gdasapp_issue_889 on Hera, Hercules, and Orion. Execute ./build.sh -v on each machine. GDAS/$machine.intel was loaded on each $machine. Build successfully ran to completion on each $machine.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 0ebe826 into NOAA-EMC:develop Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants