Butterfly effect (from @DusanJovic-NOAA) #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junwang-noaa
approved these changes
Jun 4, 2020
bensonr
reviewed
Jun 5, 2020
|
Yes, we want to add the butterfly effect on one single point, which is the
center of tile 1.
…On Fri, Jun 5, 2020 at 10:38 AM bensonr ***@***.***> wrote:
***@***.**** commented on this pull request.
The comments where the butterfly_effect logical is defined could be a
little more explicit. The logic indicates you are doing this only for the
center of tile 1.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#21 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TMFACG6CHLICU6V5W3RVD7PRANCNFSM4NR7OYAA>
.
|
bensonr
approved these changes
Jun 5, 2020
tsupinie
pushed a commit
to tsupinie/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jul 20, 2020
* Add butterfly effect option. * Move butterfly effect option from external_ic.F90 to fv_restart.F90 * model/fv_arrays.F90: provide clarification of butterfly effect in comment Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
XiaqiongZhou-NOAA
pushed a commit
to XiaqiongZhou-NOAA/GFDL_atmos_cubed_sphere
that referenced
this pull request
Feb 26, 2021
aerorahul
pushed a commit
that referenced
this pull request
Jul 17, 2021
* Add LICENSE.md * Renamed driver directories and removed the null version of the nh extensions for the public release * Update license header for FV3 * Added a README.md file * Replace GPL header with LGPL header * fixed license header in every file and added it to those without it * Master test (#17) * commit of new version of dycore from Weather and Climate Dynamics Group at GFDL * updated versions of GFDL-specific files from dev/gfdl * updated README.md with current release information * cleaned up a few lines in fv_dynamics * new file RELEASE.md with release notes documenting differences between this and the last release * updated RELEASE.md message * hand merge of diagnostic updates * remove trailing spaces from sources * updates to merge some GFDL specific updates into this public release * Master test (#18) * commit of new version of dycore from Weather and Climate Dynamics Group at GFDL * updated versions of GFDL-specific files from dev/gfdl * updated README.md with current release information * cleaned up a few lines in fv_dynamics * new file RELEASE.md with release notes documenting differences between this and the last release * updated RELEASE.md message * hand merge of diagnostic updates * remove trailing spaces from sources * updates to merge some GFDL specific updates into this public release * updated README.md * updated GFDL_tools/fv_cmip_diag to be consistent with dev/gfdl branch * Bug fix for two-way nest updating (#21) * remove trailing whitespace and any tabs * update the RELEASE.md with the FV3 technical memorandum * semantic fix in RELEASE.md * adds default values for nest_*offsets in fv_control breaks up a too long line in fv_nesting.F90 * change default value of nestupdate to 7 Co-authored-by: Seth Underwood <Seth.Underwood@noaa.gov> Co-authored-by: lharris4 <53020884+lharris4@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option flip the least-significant-bit of the lowest level temperature at the center of domain, if the newly introduced logical
butterfly_effectis set to.true.(from @DusanJovic-NOAA)This PR is tested and merged together with:
NCAR/ccpp-physics#423
NOAA-EMC/fv3atm#93
ufs-community/ufs-weather-model#94
For regression testing, see ufs-community/ufs-weather-model#94.