Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move global_cycle out of global DA jobs and scripts. #266

Closed
RussTreadon-NOAA opened this issue Dec 11, 2021 · 4 comments · Fixed by #415
Closed

Move global_cycle out of global DA jobs and scripts. #266

RussTreadon-NOAA opened this issue Dec 11, 2021 · 4 comments · Fixed by #415
Assignees
@RussTreadon-NOAA

Comments

@RussTreadon-NOAA
Copy link
Contributor

This issue is opened to document the removal of global_cycle and gaussian_sfcanl from global DA jobs and scripts. This functionality is moving into the global-workflow. This refactoring is in support of the goals stated in the JEDI Prototype 3DVar Cycling Capability project.
@RussTreadon-NOAA
Copy link
Contributor Author

RussTreadon-NOAA commented Dec 13, 2021 •
edited
Loading

Create feature/rm_sfcanl in RussTreadon-NOAA/GSI. feature/rm_sfcanl is a copy of the NOAA-EMC/GSI master at eed3d40.

RussTreadon-NOAA added a commit to RussTreadon-NOAA/GSI that referenced this issue Dec 13, 2021
@RussTreadon-NOAA
GitHub Issue NOAA-EMC#266: remove DOGCYCLE and DOGAUSFCANL scripting …
9422758 
…and variables from j-jobs and scripts

 * jobs/JGDAS_ATMOS_ANALYSIS_DIAG - remove DOGCYCLE and DOGAUSFCANL
 * jobs/JGLOBAL_ATMOS_ANALYSIS - remove DOGCYCLE and DOGAUSFCANL
 * jobs/JGLOBAL_ATMOS_ANALYSIS_CALC - remove DOGCYCLE and DOGAUSFCANL
 * scripts/exglobal_atmos_analysis.sh - remove DOGCYCLE scripting and DOGAUSFCANL variables
 * scripts/exglobal_atmos_analysis_calc.sh - remove DOGAUSFCANL scripting
RussTreadon-NOAA added a commit to RussTreadon-NOAA/GSI that referenced this issue Dec 14, 2021
@RussTreadon-NOAA
GitHub Issue NOAA-EMC#266: add DOGAUSFCANL capability back to JGLOBAL…
a75d6ed 
…_ATMOS_ANALYSIS_CALC and exglobal_atmos_analysis_calc.sh
@RussTreadon-NOAA
Copy link
Contributor Author

Closer examination of workflow dependencies indicates that the DOGAUSFCANL capability should be retained in JGLOBAL_ATMOS_ANALYSIS_CALC and exglobal_atmos_analysis_calc.sh. Doing so allows loganl.txt to retain its role as a single file logging creation of both the gaussian grid atmospheric and surface analysis files.

This also reduces the scope of feature/rm_sfcanl to simply removing global_cycle (updating surface tiles) from JGLOBAL_ATMOS_ANALYSIS. Smaller changes are easier to test and review. A new job will be added to the global workflow to execute global_cycle (see global-workflow issue #527).

Adding DOGAUSFCANL back to jobs/JGLOBAL_ATMOS_ANALYSIS_CALC and scripts/exglobal_atmos_analysis_calc.sh was done at a75d6ed.

@RussTreadon-NOAA RussTreadon-NOAA mentioned this issue Dec 14, 2021
Closed
@RussTreadon-NOAA RussTreadon-NOAA changed the title Move global_cycle and gaussian_sfcanl out of global DA jobs and scripts. Move global_cycle out of global DA jobs and scripts. Dec 15, 2021
@RussTreadon-NOAA
Copy link
Contributor Author

Both single cycle and cycled parallels have been run with the combination of changes in this issue (#266) and global-workflow issue #527.

The combination of changes in NOAA-EMC/GSI issue #266 and global-workflow issue #527 are working as intended based on single cycle and cycled testing.

@RussTreadon-NOAA
Copy link
Contributor Author

RussTreadon-NOAA commented Dec 17, 2021 •
edited
Loading

After discussions with the DA team it has been decided to place on hold the merger feature/rm_sfcanl into the master.

Currently we are collecting all changes for GFS DA v16.x in the master. This package is scheduled for implementation on WCOSS2 shortly after the WCOSS2 go-live date. GFS DA v16.x is a data upgrade only package. Workflow changes will not be made in GFS DA v16.x. This issue, #266, is a workflow change. As such, it can not enter the master until all GFS DA v16..x changes are in the master and a GFS DA v16.x release branch is created.

Issue #266 will remain open with feature/rm_sfcanl kept in sync with master updates until a future PR for issue #266 to be merged into the master is completed.

RussTreadon-NOAA added a commit to RussTreadon-NOAA/GSI that referenced this issue Jun 21, 2022
@RussTreadon-NOAA
GitHub Issue NOAA-EMC#266. remove global_cycle from DA jobs and scripts
d19b2b0 
commit 112ca82
Merge: 257f6eb dd1bac5
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Jun 21 09:56:10 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 257f6eb
Merge: 9c48261 ad84f17
Author: RussTreadon-NOAA <russ.treadon@noaa.gov>
Date:   Mon Jun 13 14:52:28 2022 +0000

    Merge branch 'develop' into feature/rm_sfcanl

commit 9c48261
Merge: dc62da7 eb220ca
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu May 26 05:43:20 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit eb220ca
Author: michael.lueken <Michael.Lueken@noaa.gov>
Date:   Wed May 25 16:04:25 2022 +0000

    GitHub Issue NOAA-EMC#382.  Add GSI fix file changes for v16.3

commit 8c22b33
Merge: a90b632 cf4b323
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Wed May 25 15:56:49 2022 +0000

    Merge pull request NOAA-EMC#374 from ADCollard/IRBugFix

    GitHub Issue NOAA-EMC#371. Minor bug fixes to IR processing

commit dc62da7
Merge: b7afecf a90b632
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Fri May 20 12:10:17 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit a90b632
Merge: 524527b 889cce5
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Fri May 20 16:08:11 2022 +0000

    Merge pull request NOAA-EMC#386 from HaixiaLiu-NOAA/master

    GitHub Issue NOAA-EMC#385. Add seviri_m09 to Radiance_Monitor util

commit 889cce5
Author: Haixia.Liu <Haixia.Liu@noaa.gov>
Date:   Fri May 20 04:27:21 2022 +0000

    GitHub Issue NOAA-EMC#385. Add seviri_m09 to Radiance_Monitor util

commit b7afecf
Merge: 58b52c6 524527b
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu May 19 12:46:19 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 524527b
Merge: 9946c69 002dc87
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu May 19 16:08:48 2022 +0000

    Merge pull request NOAA-EMC#379 from AndrewEichmann-NOAA/EXP-efso_fv3_issue_378

    Github issue NOAA-EMC#378: refactoring of EFSOI scripts and compiled code (EFSOI and EFSOI forecast scripts)

commit 9946c69
Merge: bcc0358 ccfda16
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu May 19 16:05:20 2022 +0000

    Merge pull request NOAA-EMC#381 from emilyhcliu/feature/gmi

    GitHub Issue NOAA-EMC#341. Add GMI for radmon

commit bcc0358
Merge: 7146a0b 7a4fa9b
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu May 19 16:02:55 2022 +0000

    Merge pull request NOAA-EMC#384 from christopherwharrop-noaa/feature/update-cheyenne-hpc-stack

    GitHub Issue NOAA-EMC#383 Update hpc-stack in Cheyenne modulefiles for GNU and Intel compilers.

commit 7a4fa9b
Author: Christopher Harrop <Christopher.W.Harrop@noaa.gov>
Date:   Thu May 19 09:23:33 2022 -0600

    GitHub Issue NOAA-EMC#383

    Update hpc-stack in Cheyenne modulefiles for GNU and Intel compilers.

    A small workaround was necessary for the GNU modulefile to avoid
    a dependency issue with the GNU version of hpc-stack.

commit ccfda16
Author: Emily Liu <emily.liu@noaa.gov>
Date:   Thu May 19 02:20:09 2022 +0000

    Add GMI for radmon

commit 58b52c6
Merge: c4c860b 7146a0b
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Wed May 18 14:52:48 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 7146a0b
Author: Rahul Mahajan <aerorahul@users.noreply.github.com>
Date:   Wed May 18 11:57:08 2022 -0400

    GitHub Issue NOAA-EMC#112.  A refactor of CMake build framework. (NOAA-EMC#327)

commit cf4b323
Author: Andrew Collard <andrew.collard@noaa.gov>
Date:   Fri Apr 29 21:34:22 2022 +0000

    GitHub Issue NOAA-EMC#371: Bug fixes to IR processing

commit 002dc87
Author: AndrewEichmann-NOAA <Andrew.Eichmann@noaa.gov>
Date:   Thu May 12 15:02:40 2022 -0500

    Removed extraneous lines from EFSOI script, and extraneous
    exgdas_efsoi_fcst.sh script

commit c4c860b
Merge: c9ac824 34294c1
Author: RussTreadon-NOAA <russ.treadon@noaa.gov>
Date:   Mon May 9 16:46:28 2022 +0000

    Merge branch 'develop' into feature/rm_sfcanl

commit 34294c1
Merge: ad2a3c0 20cf887
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Mon May 9 16:26:12 2022 +0000

    Merge pull request NOAA-EMC#376 from EdwardSafford-NOAA/develop

    GitHub Issue NOAA-EMC#373.  Compress RadMon data files.

commit ad2a3c0
Merge: e7f8c88 845b360
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Mon May 9 16:24:29 2022 +0000

    Merge pull request NOAA-EMC#369 from MichaelLueken-NOAA/feature/wcoss2_port

    GitHub Issue NOAA-EMC#368.  WCOSS2 port.

commit 20cf887
Author: Edward.Safford <edward.safford@noaa.gov>
Date:   Thu May 5 12:04:30 2022 +0000

    Github issue NOAA-EMC#373.  Compress RadMon data files.  Completes NOAA-EMC#373.

commit 845b360
Author: Michael Lueken <michael.lueken@noaa.gov>
Date:   Fri Apr 29 11:00:52 2022 +0000

    GitHub Issue NOAA-EMC#368.  WCOSS2 port.

commit c9ac824
Merge: e577941 e7f8c88
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue May 3 10:42:43 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit e7f8c88
Merge: 586c2df 0a5daea
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Tue May 3 10:08:34 2022 -0400

    Merge pull request NOAA-EMC#372 from RussTreadon-NOAA/feature/interp

    GitHub Issue NOAA-EMC#370: use nf90_inq_varid to set integer addresses for lon and lat variables

commit 0a5daea
Author: RussTreadon-NOAA <russ.treadon@noaa.gov>
Date:   Fri Apr 29 21:36:35 2022 +0000

    GitHub Issue NOAA-EMC/GSI NOAA-EMC#370: use nf90_inq_varid to set integer addresses for lon and lat variables

commit e577941
Merge: be550bf 586c2df
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue May 3 09:52:08 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 586c2df
Merge: 87fe77d f16e852
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Tue May 3 09:46:33 2022 -0400

    Merge pull request NOAA-EMC#366 from EdwardSafford-NOAA/develop

    GitHub Issue NOAA-EMC#310 and NOAA-EMC#367. Correct RadMon's mean correction time series plots and update html generation.

commit f16e852
Author: edward.safford <edward.safford@noaa.gov>
Date:   Fri Apr 29 14:39:22 2022 +0000

    Github issue NOAA-EMC#310.  Correct mean correction time series plots.  Fixes NOAA-EMC#310.

commit be550bf
Merge: c0a5204 114ed31
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Mon May 2 06:25:23 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit c0a5204
Merge: 8b376d1 498896b
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Mon Apr 25 13:22:30 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 8b376d1
Merge: 91a8077 0c6548e
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Wed Apr 20 13:53:51 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit 91a8077
Merge: dec3299 7201778
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Wed Apr 13 10:27:36 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit dec3299
Merge: 6204f98 5936a23
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Apr 5 10:49:24 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit 6204f98
Merge: f7a1495 affe4ed
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu Mar 31 12:38:40 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit f7a1495
Merge: b592666 ef237ce
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu Mar 24 08:57:46 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit b592666
Merge: d0f7c20 47ee70b
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu Mar 10 09:13:14 2022 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit d0f7c20
Merge: ed94193 828c0cf
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Wed Mar 2 10:35:21 2022 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit ed94193
Merge: c63bd77 963b7e5
Author: RussTreadon-NOAA <russ.treadon@noaa.gov>
Date:   Tue Mar 1 16:04:48 2022 +0000

    Merge branch 'master' at 963b7e5 into feature/rm_sfcanl

    Conflicts:
    	scripts/exglobal_atmos_analysis.sh

commit c63bd77
Merge: 39912e1 0444258
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Feb 15 06:06:10 2022 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit 39912e1
Merge: f0161c8 9e765da
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Jan 11 06:40:58 2022 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit f0161c8
Merge: a75d6ed a62dec6
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Dec 14 11:40:31 2021 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit a75d6ed
Author: russ.treadon <Russ.Treadon@noaa.gov>
Date:   Tue Dec 14 14:38:57 2021 +0000

    GitHub Issue NOAA-EMC#266:  add DOGAUSFCANL capability back to JGLOBAL_ATMOS_ANALYSIS_CALC and exglobal_atmos_analysis_calc.sh

commit 9422758
Author: russ.treadon <Russ.Treadon@noaa.gov>
Date:   Mon Dec 13 14:39:14 2021 +0000

    GitHub Issue NOAA-EMC#266:  remove DOGCYCLE and DOGAUSFCANL scripting and variables from j-jobs and scripts

     * jobs/JGDAS_ATMOS_ANALYSIS_DIAG - remove DOGCYCLE and DOGAUSFCANL
     * jobs/JGLOBAL_ATMOS_ANALYSIS - remove DOGCYCLE and DOGAUSFCANL
     * jobs/JGLOBAL_ATMOS_ANALYSIS_CALC - remove DOGCYCLE and DOGAUSFCANL
     * scripts/exglobal_atmos_analysis.sh - remove DOGCYCLE scripting and DOGAUSFCANL variables
     * scripts/exglobal_atmos_analysis_calc.sh - remove DOGAUSFCANL scripting
RussTreadon-NOAA added a commit to RussTreadon-NOAA/GSI that referenced this issue Jun 23, 2022
@RussTreadon-NOAA
GitHub Issue NOAA-EMC#266. remove global_cycle from DA jobs and scripts
009b74d
@MichaelLueken MichaelLueken linked a pull request Jun 23, 2022 that will close this issue
GitHub Issue NOAA-EMC/GSI#266. remove global_cycle from DA jobs and scripts #415
Merged
MichaelLueken added a commit that referenced this issue Jun 23, 2022
@MichaelLueken
Merge pull request #415 from RussTreadon-NOAA/develop
2570e90 
GitHub Issue #266.  remove global_cycle from DA jobs and scripts
aerorahul pushed a commit to NOAA-EMC/global-workflow that referenced this issue Jul 12, 2022
@RussTreadon-NOAA
GitHub Issue NOAA-EMC/GSI#266. remove global_cycle from DA jobs and s…
d34aa13 
…cripts
aerorahul pushed a commit to NOAA-EMC/global-workflow that referenced this issue Jul 12, 2022
@MichaelLueken
Merge pull request #415 from RussTreadon-NOAA/develop
0e3c259 
GitHub Issue NOAA-EMC/GSI#266.  remove global_cycle from DA jobs and scripts
aerorahul pushed a commit to NOAA-EMC/global-workflow that referenced this issue Jul 12, 2022
@RussTreadon-NOAA
GitHub Issue NOAA-EMC/GSI#266. remove global_cycle from DA jobs and s…
ddf5504 
…cripts
aerorahul pushed a commit to NOAA-EMC/global-workflow that referenced this issue Jul 12, 2022
@MichaelLueken
Merge pull request #415 from RussTreadon-NOAA/develop
9be720f 
GitHub Issue NOAA-EMC/GSI#266.  remove global_cycle from DA jobs and scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub Issue NOAA-EMC/GSI#266. remove global_cycle from DA jobs and scripts RussTreadon-NOAA/GSI
1 participant
@RussTreadon-NOAA