Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GSI fix files changes for v16.3 #382

Closed
emilyhcliu opened this issue May 19, 2022 · 21 comments
Closed

Add GSI fix files changes for v16.3 #382

emilyhcliu opened this issue May 19, 2022 · 21 comments
Assignees

Comments

@emilyhcliu
Copy link
Contributor

A GSI fix branch has been created to collect any changes for v16.3
The name of the branch is called: fix_v16.3
Please update GSI master in your fork and check out fix_v16.3 under fix directory

@MichaelLueken
Copy link
Contributor

@emilyhcliu Are these modifications ready to be committed to the authoritative repository? Want to make sure before I move forward with these changes.

@ADCollard
Copy link
Contributor

Changed use flag from -1 to 1 for Meteosat-9 AMVs (satid = 9) in global_convinfo.txt

@HaixiaLiu-NOAA
Copy link
Contributor

Modified global_ozinfo.txt: adjusted obs errors and gross errors for the top 5 layer OMPSNP data. Add entry for ompslp_n21

@HaixiaLiu-NOAA
Copy link
Contributor

@emilyhcliu how do you want to take care of the iuse change associated with Meteosat 8/9 switch on 6/1/2022? Should I create a new global_satinfo.txt file in the directory gfsv16_historical?

@emilyhcliu
Copy link
Contributor Author

Set AVHRR MetOp-C AMV to 1 (244, 5, 1)
We begin to receive new format of B and C from March
The old format will continue until June
So, we will have both formats from March to June

The new format requires code changes and they are in develop already

AVHRR B and C will be in v16.3

There is no way to add the switch of AB to BC since NCO does not allow code change.

@emilyhcliu
Copy link
Contributor Author

@emilyhcliu Are these modifications ready to be committed to the authoritative repository? Want to make sure before I move forward with these changes.

@MichaelLueken-NOAA Yes, these changes will go into the authoritative repository

@emilyhcliu
Copy link
Contributor Author

@emilyhcliu how do you want to take care of the iuse change associated with Meteosat 8/9 switch on 6/1/2022? Should I create a new global_satinfo.txt file in the directory gfsv16_historical?

@HaixiaLiu-NOAA Will the switch of Meteosat8/9 definitely occur on 6/1/2022?

@ADCollard
Copy link
Contributor

@emilyhcliu how do you want to take care of the iuse change associated with Meteosat 8/9 switch on 6/1/2022? Should I create a new global_satinfo.txt file in the directory gfsv16_historical?

@HaixiaLiu-NOAA Will the switch of Meteosat8/9 definitely occur on 6/1/2022?

@HaixiaLiu-NOAA @emilyhcliu There should be no need to worry about historical fix for Meteosat 8/9 AMVs as both are set to +1. The GSI will process whichever is in the dump file, so this is transparent to GSI once M9 is set to +1.

@emilyhcliu
Copy link
Contributor Author

@emilyhcliu how do you want to take care of the iuse change associated with Meteosat 8/9 switch on 6/1/2022? Should I create a new global_satinfo.txt file in the directory gfsv16_historical?

@HaixiaLiu-NOAA Will the switch of Meteosat8/9 definitely occur on 6/1/2022?

@HaixiaLiu-NOAA @emilyhcliu There should be no need to worry about historical fix for Meteosat 8/9 AMVs as both are set to +1. The GSI will process whichever is in the dump file, so this is transparent to GSI once M9 is set to +1.

@ADCollard @HaixiaLiu-NOAA is thinking about the Meteosat8/9 switch for radiances.

@emilyhcliu
Copy link
Contributor Author

@HaixiaLiu-NOAA @ADCollard
MeteoSat-9 is becoming operational satellite on June 1, 2022.
And, if the operational data stream (dump) will only contain data from operational satellite, then we can set the use flag to 1 for both MeteoSat-8 and MeteoSat-9 in the satinfo file. GSI will process whichever is in the dump file (just like Andrew pointed out).
This should also be the case for Himawari-8 and Himawari-9 CSR data.
Does this make sense to you?

@haixia, the seviri_m09 is not ready for radmon. Please open an PR to add that in.

@HaixiaLiu-NOAA
Copy link
Contributor

@emilyhcliu @ADCollard I am not sure if CSR dumps generated in a similar way to the AMV dumps (i.e., only data from primary satellite are tanked and dumped). We need to ask Jeff and Iliana about this.

I will open a PR to add seviri_m09 into the radmon

@HaixiaLiu-NOAA
Copy link
Contributor

The PR to add seviri_m09 into the RadMon has been opened. Please review it @emilyhcliu.

@emilyhcliu
Copy link
Contributor Author

The PR to add seviri_m09 into the RadMon has been opened. Please review it @emilyhcliu.
@HaixiaLiu-NOAA thanks! Reviewed and approved!

@emilyhcliu
Copy link
Contributor Author

@HaixiaLiu-NOAA @ADCollard MeteoSat-9 is becoming operational satellite on June 1, 2022. And, if the operational data stream (dump) will only contain data from operational satellite, then we can set the use flag to 1 for both MeteoSat-8 and MeteoSat-9 in the satinfo file. GSI will process whichever is in the dump file (just like Andrew pointed out). This should also be the case for Himawari-8 and Himawari-9 CSR data. Does this make sense to you?

@haixia, the seviri_m09 is not ready for radmon. Please open an PR to add that in.

@HaixiaLiu-NOAA @ADCollard Am I correct that we should set the use flag to 1 for both Himarari-8 and Himarari-9 in satinfo file? The same fot MeteoSat-8 and MeteoSat-9. Any thoughts?

@HaixiaLiu-NOAA
Copy link
Contributor

@emilyhcliu I do not know if it is true that the CSR dumps will have similar situation as AMV for Meteosat 8/9 and Himawari8/9 (i.e. only data from primary satellite are in the operational tanks/dumps) I will send an email to Jeff/Iliana to check on that. Or could we wait till 6/1/2022 to check the operational CSR dumps to see if it is the case? When do you want to start the para for v16.3?

@emilyhcliu
Copy link
Contributor Author

@HaixiaLiu-NOAA Ok, thanks for your explanation. Please go ahead and ask the question to Jeff/Iliana.
If we can not get a confirmed answer from them, we will just keep the use flag to -1 for Himawari-9 and MeteoSat-9 We can change it later.

@HaixiaLiu-NOAA
Copy link
Contributor

@emilyhcliu we will need to keep iuse=-1 for Meteosat-9 and Himawari9 before the data in operational dump (6/1/2022 for Meteosat-09 and to be determined for Himawari-9) due to the bias correction spinup required to correctly use the CSR data from both instruments.

@MichaelLueken
Copy link
Contributor

@emilyhcliu @ADCollard @HaixiaLiu-NOAA Are there any more changes to the fix files for GFS v16.3, or will I be able to update the fix files to use fix_v16.3 tomorrow after merging in @ADCollard PR #374?

@emilyhcliu
Copy link
Contributor Author

@MichaelLueken-NOAA Changes for fix_v16.3 are all in place now. I will work with developers to make sure changes will be all in by the end of today. So, yes, please go ahead to update the fix after merging in Andrew's PR tomorrow.

@MichaelLueken
Copy link
Contributor

The fix files changes in fix/fix_v16.3 have been merged to fix/rev2 and updated in the authoritative repository at eb220ca. Will keep this issue open until all potential fix file changes have been applied.

@emilyhcliu
Copy link
Contributor Author

@MichaelLueken-NOAA Thanks. Yes, Keep this issue open for the v16.3 release branch.

AndrewEichmann-NOAA pushed a commit to AndrewEichmann-NOAA/GSI that referenced this issue Jun 6, 2022
RussTreadon-NOAA added a commit to RussTreadon-NOAA/GSI that referenced this issue Jun 21, 2022
commit 112ca82
Merge: 257f6eb dd1bac5
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Jun 21 09:56:10 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 257f6eb
Merge: 9c48261 ad84f17
Author: RussTreadon-NOAA <russ.treadon@noaa.gov>
Date:   Mon Jun 13 14:52:28 2022 +0000

    Merge branch 'develop' into feature/rm_sfcanl

commit 9c48261
Merge: dc62da7 eb220ca
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu May 26 05:43:20 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit eb220ca
Author: michael.lueken <Michael.Lueken@noaa.gov>
Date:   Wed May 25 16:04:25 2022 +0000

    GitHub Issue NOAA-EMC#382.  Add GSI fix file changes for v16.3

commit 8c22b33
Merge: a90b632 cf4b323
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Wed May 25 15:56:49 2022 +0000

    Merge pull request NOAA-EMC#374 from ADCollard/IRBugFix

    GitHub Issue NOAA-EMC#371. Minor bug fixes to IR processing

commit dc62da7
Merge: b7afecf a90b632
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Fri May 20 12:10:17 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit a90b632
Merge: 524527b 889cce5
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Fri May 20 16:08:11 2022 +0000

    Merge pull request NOAA-EMC#386 from HaixiaLiu-NOAA/master

    GitHub Issue NOAA-EMC#385. Add seviri_m09 to Radiance_Monitor util

commit 889cce5
Author: Haixia.Liu <Haixia.Liu@noaa.gov>
Date:   Fri May 20 04:27:21 2022 +0000

    GitHub Issue NOAA-EMC#385. Add seviri_m09 to Radiance_Monitor util

commit b7afecf
Merge: 58b52c6 524527b
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu May 19 12:46:19 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 524527b
Merge: 9946c69 002dc87
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu May 19 16:08:48 2022 +0000

    Merge pull request NOAA-EMC#379 from AndrewEichmann-NOAA/EXP-efso_fv3_issue_378

    Github issue NOAA-EMC#378: refactoring of EFSOI scripts and compiled code (EFSOI and EFSOI forecast scripts)

commit 9946c69
Merge: bcc0358 ccfda16
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu May 19 16:05:20 2022 +0000

    Merge pull request NOAA-EMC#381 from emilyhcliu/feature/gmi

    GitHub Issue NOAA-EMC#341. Add GMI for radmon

commit bcc0358
Merge: 7146a0b 7a4fa9b
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Thu May 19 16:02:55 2022 +0000

    Merge pull request NOAA-EMC#384 from christopherwharrop-noaa/feature/update-cheyenne-hpc-stack

    GitHub Issue NOAA-EMC#383 Update hpc-stack in Cheyenne modulefiles for GNU and Intel compilers.

commit 7a4fa9b
Author: Christopher Harrop <Christopher.W.Harrop@noaa.gov>
Date:   Thu May 19 09:23:33 2022 -0600

    GitHub Issue NOAA-EMC#383

    Update hpc-stack in Cheyenne modulefiles for GNU and Intel compilers.

    A small workaround was necessary for the GNU modulefile to avoid
    a dependency issue with the GNU version of hpc-stack.

commit ccfda16
Author: Emily Liu <emily.liu@noaa.gov>
Date:   Thu May 19 02:20:09 2022 +0000

    Add GMI for radmon

commit 58b52c6
Merge: c4c860b 7146a0b
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Wed May 18 14:52:48 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 7146a0b
Author: Rahul Mahajan <aerorahul@users.noreply.github.com>
Date:   Wed May 18 11:57:08 2022 -0400

    GitHub Issue NOAA-EMC#112.  A refactor of CMake build framework. (NOAA-EMC#327)

commit cf4b323
Author: Andrew Collard <andrew.collard@noaa.gov>
Date:   Fri Apr 29 21:34:22 2022 +0000

    GitHub Issue NOAA-EMC#371: Bug fixes to IR processing

commit 002dc87
Author: AndrewEichmann-NOAA <Andrew.Eichmann@noaa.gov>
Date:   Thu May 12 15:02:40 2022 -0500

    Removed extraneous lines from EFSOI script, and extraneous
    exgdas_efsoi_fcst.sh script

commit c4c860b
Merge: c9ac824 34294c1
Author: RussTreadon-NOAA <russ.treadon@noaa.gov>
Date:   Mon May 9 16:46:28 2022 +0000

    Merge branch 'develop' into feature/rm_sfcanl

commit 34294c1
Merge: ad2a3c0 20cf887
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Mon May 9 16:26:12 2022 +0000

    Merge pull request NOAA-EMC#376 from EdwardSafford-NOAA/develop

    GitHub Issue NOAA-EMC#373.  Compress RadMon data files.

commit ad2a3c0
Merge: e7f8c88 845b360
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Mon May 9 16:24:29 2022 +0000

    Merge pull request NOAA-EMC#369 from MichaelLueken-NOAA/feature/wcoss2_port

    GitHub Issue NOAA-EMC#368.  WCOSS2 port.

commit 20cf887
Author: Edward.Safford <edward.safford@noaa.gov>
Date:   Thu May 5 12:04:30 2022 +0000

    Github issue NOAA-EMC#373.  Compress RadMon data files.  Completes NOAA-EMC#373.

commit 845b360
Author: Michael Lueken <michael.lueken@noaa.gov>
Date:   Fri Apr 29 11:00:52 2022 +0000

    GitHub Issue NOAA-EMC#368.  WCOSS2 port.

commit c9ac824
Merge: e577941 e7f8c88
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue May 3 10:42:43 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit e7f8c88
Merge: 586c2df 0a5daea
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Tue May 3 10:08:34 2022 -0400

    Merge pull request NOAA-EMC#372 from RussTreadon-NOAA/feature/interp

    GitHub Issue NOAA-EMC#370: use nf90_inq_varid to set integer addresses for lon and lat variables

commit 0a5daea
Author: RussTreadon-NOAA <russ.treadon@noaa.gov>
Date:   Fri Apr 29 21:36:35 2022 +0000

    GitHub Issue NOAA-EMC/GSI NOAA-EMC#370: use nf90_inq_varid to set integer addresses for lon and lat variables

commit e577941
Merge: be550bf 586c2df
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue May 3 09:52:08 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 586c2df
Merge: 87fe77d f16e852
Author: MichaelLueken-NOAA <63728921+MichaelLueken-NOAA@users.noreply.github.com>
Date:   Tue May 3 09:46:33 2022 -0400

    Merge pull request NOAA-EMC#366 from EdwardSafford-NOAA/develop

    GitHub Issue NOAA-EMC#310 and NOAA-EMC#367. Correct RadMon's mean correction time series plots and update html generation.

commit f16e852
Author: edward.safford <edward.safford@noaa.gov>
Date:   Fri Apr 29 14:39:22 2022 +0000

    Github issue NOAA-EMC#310.  Correct mean correction time series plots.  Fixes NOAA-EMC#310.

commit be550bf
Merge: c0a5204 114ed31
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Mon May 2 06:25:23 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit c0a5204
Merge: 8b376d1 498896b
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Mon Apr 25 13:22:30 2022 -0400

    Merge branch 'NOAA-EMC:develop' into feature/rm_sfcanl

commit 8b376d1
Merge: 91a8077 0c6548e
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Wed Apr 20 13:53:51 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit 91a8077
Merge: dec3299 7201778
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Wed Apr 13 10:27:36 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit dec3299
Merge: 6204f98 5936a23
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Apr 5 10:49:24 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit 6204f98
Merge: f7a1495 affe4ed
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu Mar 31 12:38:40 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit f7a1495
Merge: b592666 ef237ce
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu Mar 24 08:57:46 2022 -0400

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit b592666
Merge: d0f7c20 47ee70b
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Thu Mar 10 09:13:14 2022 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit d0f7c20
Merge: ed94193 828c0cf
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Wed Mar 2 10:35:21 2022 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit ed94193
Merge: c63bd77 963b7e5
Author: RussTreadon-NOAA <russ.treadon@noaa.gov>
Date:   Tue Mar 1 16:04:48 2022 +0000

    Merge branch 'master' at 963b7e5 into feature/rm_sfcanl

    Conflicts:
    	scripts/exglobal_atmos_analysis.sh

commit c63bd77
Merge: 39912e1 0444258
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Feb 15 06:06:10 2022 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit 39912e1
Merge: f0161c8 9e765da
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Jan 11 06:40:58 2022 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit f0161c8
Merge: a75d6ed a62dec6
Author: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
Date:   Tue Dec 14 11:40:31 2021 -0500

    Merge branch 'NOAA-EMC:master' into feature/rm_sfcanl

commit a75d6ed
Author: russ.treadon <Russ.Treadon@noaa.gov>
Date:   Tue Dec 14 14:38:57 2021 +0000

    GitHub Issue NOAA-EMC#266:  add DOGAUSFCANL capability back to JGLOBAL_ATMOS_ANALYSIS_CALC and exglobal_atmos_analysis_calc.sh

commit 9422758
Author: russ.treadon <Russ.Treadon@noaa.gov>
Date:   Mon Dec 13 14:39:14 2021 +0000

    GitHub Issue NOAA-EMC#266:  remove DOGCYCLE and DOGAUSFCANL scripting and variables from j-jobs and scripts

     * jobs/JGDAS_ATMOS_ANALYSIS_DIAG - remove DOGCYCLE and DOGAUSFCANL
     * jobs/JGLOBAL_ATMOS_ANALYSIS - remove DOGCYCLE and DOGAUSFCANL
     * jobs/JGLOBAL_ATMOS_ANALYSIS_CALC - remove DOGCYCLE and DOGAUSFCANL
     * scripts/exglobal_atmos_analysis.sh - remove DOGCYCLE scripting and DOGAUSFCANL variables
     * scripts/exglobal_atmos_analysis_calc.sh - remove DOGAUSFCANL scripting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants