Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSI GitHub Issue NOAA-EMC/GSI#228. Port ConMon to wcoss2. #255

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

EdwardSafford-NOAA
Copy link
Contributor

Initial port of ConMon to wcoss2. No part of the ConMon is currently in operations so the GSI/master fork has been used for this port. Also note that while testing has been completed successfully on wcoss2, the minimal data set available hardly provides a real world stress test, so adjustments may well have to be made once operational data (or expanded testing data) becomes available.

@MichaelLueken MichaelLueken linked an issue Nov 17, 2021 that may be closed by this pull request
@MichaelLueken MichaelLueken changed the title GSI #228. Port ConMon to wcoss2. This completes #228. GSI GitHub Issue NOAA-EMC/GSI#228. Port ConMon to wcoss2. Nov 17, 2021
@MichaelLueken
Copy link
Contributor

Hi @EdwardSafford-NOAA,

Would you like a review, or are these changes ready to be merged to the master?

Thanks,

Mike

@EdwardSafford-NOAA
Copy link
Contributor Author

Hi @MichaelLueken-NOAA ,

The changes involve no operational code and are limited to the ConMon so I think they can be merged to master. As I mentioned above I might have more work to do once a full set of data is available on wcoss2.

Thanks,
Ed

@MichaelLueken
Copy link
Contributor

I will now give final approval to these changes and merge them to the authoritative master.

@MichaelLueken MichaelLueken merged commit f442020 into NOAA-EMC:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port ConMon to wcoss2
2 participants