-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Issue NOAA-EMC/GSI#406. Remove observation monitoring tools #407
GitHub Issue NOAA-EMC/GSI#406. Remove observation monitoring tools #407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes remove the DA monitoring packages and bring in the changes which have been merged to release/gfsda.v16.3.0. There is work that is currently out for review, but once that work has been merged, I can move forward with these changes. However, before doing so, please reduce the number of commits from 2 to 1, as per the directions in the wiki:
- git reset --soft HEAD~1
- git commit --amend
- Please add:
GitHub Issue NOAA-EMC/GSI#406.
to the commit message.
GitHub Issue NOAA-EMC/GSI#406. Remove observation monitoring tools
- git push origin feature/remove_gsi_monitoring --force
Once these steps are complete, I will be able to merge this after the current work has been merged later this week.
Merge pull request NOAA-EMC#396 from TingLei-daprediction/feature/reg_read_loc_388 GitHub Issue NOAA-EMC#388. Verification of readin_localization=.true. for regional GSI.
9f7c287
to
d4b4833
Compare
done. |
@aerorahul @EdwardSafford-NOAA I'm planning on merging this update to the authoritative |
IMO, the GSI-monitor should be part of the application and not part of the GSI repository. |
Since this update is removing the observation monitoring tools from the authoritative develop branch, I will go ahead and merge these changes to the authoritative develop branch. |
closes #406