Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue NOAA-EMC/GSI#406. Remove observation monitoring tools #407

Merged

Conversation

aerorahul
Copy link
Contributor

closes #406

Copy link
Contributor

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes remove the DA monitoring packages and bring in the changes which have been merged to release/gfsda.v16.3.0. There is work that is currently out for review, but once that work has been merged, I can move forward with these changes. However, before doing so, please reduce the number of commits from 2 to 1, as per the directions in the wiki:

  1. git reset --soft HEAD~1
  2. git commit --amend
  3. Please add:
    GitHub Issue NOAA-EMC/GSI#406.
    to the commit message.
    GitHub Issue NOAA-EMC/GSI#406. Remove observation monitoring tools
  4. git push origin feature/remove_gsi_monitoring --force

Once these steps are complete, I will be able to merge this after the current work has been merged later this week.

Merge pull request NOAA-EMC#396 from TingLei-daprediction/feature/reg_read_loc_388

GitHub Issue NOAA-EMC#388. Verification of readin_localization=.true. for regional GSI.
@aerorahul aerorahul force-pushed the feature/remove_gsi_monitoring branch from 9f7c287 to d4b4833 Compare June 6, 2022 14:46
@aerorahul
Copy link
Contributor Author

These changes remove the DA monitoring packages and bring in the changes which have been merged to release/gfsda.v16.3.0. There is work that is currently out for review, but once that work has been merged, I can move forward with these changes. However, before doing so, please reduce the number of commits from 2 to 1, as per the directions in the wiki:

  1. git reset --soft HEAD~1
  2. git commit --amend
  3. Please add:
    GitHub Issue NOAA-EMC/GSI#406.
    to the commit message.
    GitHub Issue NOAA-EMC/GSI#406. Remove observation monitoring tools
  4. git push origin feature/remove_gsi_monitoring --force

Once these steps are complete, I will be able to merge this after the current work has been merged later this week.

done.

@MichaelLueken
Copy link
Contributor

@aerorahul @EdwardSafford-NOAA I'm planning on merging this update to the authoritative develop branch tomorrow. I was wondering what the plan is to bring in the monitoring package moving forward. Will the NOAA-EMC/GSI-Monitor repository be linked to NOAA-EMC/GSI through an external, or will each workflow that uses the monitoring packages need to be updated to add a checkout to the new GSI-Monitor project? If an external will be used, should this be included with the removal of the monitoring package from the GSI repository? I'd like clarification on the path forward before merging this work to the authoritative develop branch.

@aerorahul
Copy link
Contributor Author

@aerorahul @EdwardSafford-NOAA I'm planning on merging this update to the authoritative develop branch tomorrow. I was wondering what the plan is to bring in the monitoring package moving forward. Will the NOAA-EMC/GSI-Monitor repository be linked to NOAA-EMC/GSI through an external, or will each workflow that uses the monitoring packages need to be updated to add a checkout to the new GSI-Monitor project? If an external will be used, should this be included with the removal of the monitoring package from the GSI repository? I'd like clarification on the path forward before merging this work to the authoritative develop branch.

IMO, the GSI-monitor should be part of the application and not part of the GSI repository.
So adding relevant bits to the workflow to build the monitoring toolset.

@MichaelLueken MichaelLueken changed the title remove observation monitoring tools GitHub Issue NOAA-EMC/GSI#406. Remove observation monitoring tools Jun 10, 2022
@MichaelLueken
Copy link
Contributor

Since this update is removing the observation monitoring tools from the authoritative develop branch, I will go ahead and merge these changes to the authoritative develop branch.

@MichaelLueken MichaelLueken merged commit 9ea4429 into NOAA-EMC:develop Jun 10, 2022
@aerorahul aerorahul deleted the feature/remove_gsi_monitoring branch June 13, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove GSI Observation Monitoring Utilities from the GSI repository
2 participants