GitHub Issue NOAA-EMC/GSI#413. Correct incorrect variables in LUA modulefiles.

[MichaelLueken]

• gsi_hera.gnu.lua - replaced:

local hpc_intel_ver=os.getenv("hpc_gnu_ver") or "9.2.0"
local impi_ver=os.getenv("hpc_mpich_ver") or "3.3.2"

with:

local hpc_gnu_ver=os.getenv("hpc_gnu_ver") or "9.2.0"
local hpc_mpich_ver=os.getenv("hpc_mpich_ver") or "3.3.2"

• gsi_hera.intel.lua - replaced:

local impi_ver=os.getenv("hpc_impi_ver") or "2018.0.4"
with:
local hpc_impi_ver=os.getenv("hpc_impi_ver") or "2018.0.4"

• gsi_orion.lua - replaced:

local impi_ver=os.getenv("hpc_impi_ver") or "2018.4"
with:
local hpc_impi_ver=os.getenv("hpc_impi_ver") or "2018.4"

• gsi_s4.lua - replaced:

local impi_ver=os.getenv("hpc_impi_ver") or "18.0.4"
with:
local hpc_impi_ver=os.getenv("hpc_impi_ver") or "18.0.4"

• gsi_wcoss_dell_p3.lua - replaced:

local hpc_intel_ver=os.getenv("hpc_ips_ver") or "18.0.1.163"
local impi_ver=os.getenv("hpc_impi_ver") or "18.0.1"

with:

local hpc_ips_ver=os.getenv("hpc_ips_ver") or "18.0.1.163"
local hpc_impi_ver=os.getenv("hpc_impi_ver") or "18.0.1"

Fixes #413

[aerorahul]

Thank you for a thorough review and update at the modulefiles.
I certainly copy/pasted from one that was checked.

[MichaelLueken]

These changes have been tested on WCOSS and Hera and were approved. I will now merge this work to the authoritative develop branch.