Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off enspread reg #635

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

ShunLiu-NOAA
Copy link
Contributor

@ShunLiu-NOAA ShunLiu-NOAA commented Oct 3, 2023

Description

In cplr_get_fv3_regional_ensperts.f90, "write_ens_sprd=.true." is hard-coded and overwrites the values in namelist.
write_ens_sprd=.true." should be removed.

Fixes #634

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@hu5970 hu5970 self-assigned this Oct 4, 2023
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward change which restores user control of write_spread_ens for fv3_regional via HYBRID_ENSEMBLE namelist.

@ShunLiu-NOAA
Copy link
Contributor Author

@TingLei-NOAA and @RussTreadon-NOAA, thank you for approving this PR. I am going to start regression test.

@hu5970
Copy link
Collaborator

hu5970 commented Oct 4, 2023

The regression tests on Hera:

Test project /scratch1/BMC/wrfruc/mhu/gsi/GSI/build
    Start 1: global_3dvar
    Start 2: global_4dvar
    Start 3: global_4denvar
    Start 4: hwrf_nmm_d2
    Start 5: hwrf_nmm_d3
    Start 6: rtma
    Start 7: rrfs_3denvar_glbens
    Start 8: netcdf_fv3_regional
    Start 9: global_enkf


1/9 Test #7: rrfs_3denvar_glbens ..............***Failed  673.07 sec
2/9 Test #5: hwrf_nmm_d3 ......................   Passed  683.88 sec
3/9 Test #4: hwrf_nmm_d2 ......................   Passed  731.31 sec
4/9 Test #8: netcdf_fv3_regional ..............   Passed  731.36 sec
5/9 Test #9: global_enkf ......................   Passed  1092.91 sec
6/9 Test #6: rtma .............................   Passed  1454.80 sec
7/9 Test #3: global_4denvar ...................   Passed  1729.82 sec
8/9 Test #2: global_4dvar .....................   Passed  1865.74 sec
9/9 Test #1: global_3dvar .....................   Passed  1969.45 sec

89% tests passed, 1 tests failed out of 9

Total Test time (real) = 1969.47 sec

The following tests FAILED:
	  7 - rrfs_3denvar_glbens (Failed)

The failure of rrfs_3denvar_glbens is "Failed the scalability test". This is not a fatal failure.
The regression test passed on Hera

@ShunLiu-NOAA
Copy link
Contributor Author

Test project /lfs/h2/emc/lam/noscrub/emc.lam/Shun.Liu/gsi_regression/GSI/build
Start 1: global_3dvar
1/9 Test #1: global_3dvar ..................... Passed 1672.98 sec
Start 2: global_4dvar
2/9 Test #2: global_4dvar ..................... Passed 1685.60 sec
Start 3: global_4denvar
3/9 Test #3: global_4denvar ................... Passed 1495.32 sec
Start 4: hwrf_nmm_d2
4/9 Test #4: hwrf_nmm_d2 ...................... Passed 727.12 sec
Start 5: hwrf_nmm_d3
5/9 Test #5: hwrf_nmm_d3 ...................... Passed 492.70 sec
Start 6: rtma
6/9 Test #6: rtma ............................. Passed 1208.46 sec
Start 7: rrfs_3denvar_glbens
7/9 Test #7: rrfs_3denvar_glbens .............. Passed 605.06 sec
Start 8: netcdf_fv3_regional
8/9 Test #8: netcdf_fv3_regional ..............***Failed 483.17 sec
Start 9: global_enkf
9/9 Test #9: global_enkf ...................... Passed 1107.32 sec

89% tests passed, 1 tests failed out of 9

Total Test time (real) = 9477.82 sec

The following tests FAILED:
8 - netcdf_fv3_regional (Failed)
Errors while running CTest

The failure of netcdf_fv3_regional is "Failed the scalability test". This is not a fatal failure.
The regression test passed on WCOSS2

@hu5970 hu5970 merged commit 25306a2 into NOAA-EMC:develop Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove "write_ens_sprd=.true."
5 participants