-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hera intel modulefile to Rocky 8 #715
Update Hera intel modulefile to Rocky 8 #715
Conversation
@DavidHuber-NOAA , this PR contains changes required to build and run GSI on Hera Rocky 8 nodes. Cross link this PR with g-w #2329 |
Hera intel Rocky 8 test Build
The global_4denvar failure is due to
A check of the
This is not a fatal fail. |
@DavidHuber-NOAA , while I can build
This is the first time I have tried to run GSI ctests with gnu executables. Have you run gnu executables in GSI ctests? If "yes", what changes were necessary to make this work? |
@RussTreadon-NOAA I was able to run the ctests with gnu executables on Hera-CentOS. Most would fail, but not due to library linking issues. The UFS appears to be going through similar issues with GNU compilers on Rocky8 (see ufs-community/ufs-weather-model#2143 (comment)) and the issue appears to be related to slurm. I also wonder if openmpi needs to be recompiled for Rocky8. The installation the GSI and UFS are using was compiled on CentOS. I asked that question on spack-stack here. Personally, I am OK with just updating the Intel modulefile for now and returning to GNU when the issues are resolved. |
Thank you @DavidHuber-NOAA . Good to know the GSI is not alone when it comes to challenges running gnu executables on Hera Rocky 8 nodes. I agree with you. Let me revert the change to |
This reverts commit bf0505d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works in my test.
Thank you @hu5970 for testing the changes in this PR. Good to hear that it works for you. Question for @ShunLiu-NOAA , @CoryMartin-NOAA , you, and me:
|
Works for me. I take your reply, @ShunLiu-NOAA, to mean that you prefer merging after the 4/2 transition is complete. Is this correct? |
I vote to merge after 3/19, that way we have people starting to rebuild beforehand and then on 4/2, people can move ahead with their science. |
Agree merge after 3/19. |
@DavidHuber-NOAA , we plan on merging this PR into GSI |
@DavidHuber-NOAA and @HenryWinterbottom-NOAA : We can merge this PR into GSI |
@RussTreadon-NOAA That sounds good to us, thanks! |
RDHPCS admins informed users that after the 3/19 Hera maintenance the default for users logging into Hera will be Rocky 8. You will have to hit ^C and select one of hfe01-hfe04 to access a CentOS 7 login node. All jobs submitted from a Rocky 8 login node will run on Rocky 8 compute nodes. Given this we should merge this PR into |
@DavidHuber-NOAA, would you be able to serve as a peer reviewer for this PR? |
Yes, I'm happy to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the environment path has been updated correctly. Approve.
@ShunLiu-NOAA , @hu5970 , & @CoryMartin-NOAA , we need to merge this PR into |
I'm fine with either. No one will be using Hera tomorrow and no one should be building CentOS7 today on Hera anyways. |
Thank you Russ. I'm fine with either too.
Shun
…On Mon, Mar 18, 2024 at 1:55 PM RussTreadon-NOAA ***@***.***> wrote:
@ShunLiu-NOAA <https://github.com/ShunLiu-NOAA> , @hu5970
<https://github.com/hu5970> , & @CoryMartin-NOAA
<https://github.com/CoryMartin-NOAA> , we need to merge this PR into
develop and pass a new gsi_enkf.fd hash to the g-w team. When shall we
merge this PR into develop - today (3/18) or tomorrow (3/19)?
—
Reply to this email directly, view it on GitHub
<#715 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACD5GZYAOQ24WW4TKYOIW3DYY4TAVAVCNFSM6AAAAABESY35ZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGU3TQNZWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@HenryWinterbottom-NOAA and @aerorahul : The GSI Hera intel build has been updated to Rocky 8. Done at dfb958f |
DUE DATE for merger of this PR into
develop
is 4/23/2024 (six weeks after PR creation).Description
This PR updates the Hera intel modulefile to build
gsi.x
andenkf.x
on Rocky 8 nodes.Fixes #710
Fixes #711
Type of change
How Has This Been Tested?
Checklist