Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit_tests #11

Merged
merged 16 commits into from
Jul 28, 2020
Merged

add unit_tests #11

merged 16 commits into from
Jul 28, 2020

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jul 18, 2020

This PR adds unit tests from @jbathegit .

  • It includes a bugfix, where c_hdr were not available under build interface.
  • Adds ctests for tests from @jbathegit
  • README is translated into Markdown format.
  • The test data is downloaded from https://ftp.emc.ncep.noaa.gov/public/bufr.tar.
  • added github action to run tests on push and PR.

Testing:

  • All _4 and _d tests pass. _8 tests don't. I think that is expected.
  • OUT3 tests do not compile on GNU and hence cannot be tested. Compiles and runs on Intel.

Help wanted!
I cannot figure out why test_OUT_3.f won't compile with GNU and dynamic allocation.
On Intel, the test compiles.

On Intel and GNU, _8 tests exhibit failures. This will need careful look at the test codes itself.

Change-Id: Id74f6e9da78967d1c8261f0b6c35669a7fc1648b
Change-Id: Idbc96de69e3eb277640ace5470c1ccda74535bef
Change-Id: I607151c32e0a8a1f3313cfc341d244a3c6028e21
Change-Id: Ia8c843c860df376b821d317d8f3cdce5ade5f0b9
Change-Id: I96ab6110eb7766e4d7ffe0c1a867d12f3213cb51
Change-Id: I353bd3986a01ad48f37948fa0bd75d17b9e1717e
… test data to the repo

Change-Id: I898c3b8cf0bc4183d97239daee894c86ef9d7663
… test_out_3 cannot compile

Change-Id: I76b13609113b65f22d53625b49f9da33ff73cc39
@aerorahul aerorahul added enhancement New feature or request help wanted Extra attention is needed labels Jul 18, 2020
Change-Id: I1ee5482913731c8167d43c1c71e8722faa9c50b9
Change-Id: Ibfae1474d6ef1271b3c6fa8bbd5ab909a168860d
@mark-a-potts
Copy link
Contributor

All the tests other than the _8 ones pass for me using both GNU and Intel on Hera.

@aerorahul
Copy link
Contributor Author

I think @jbathegit did not intend to run test the _8 library, but I may be wrong.
we can wait for @jbathegit to return and give us instructions oh how he wishes to proceed.

@aerorahul
Copy link
Contributor Author

Changing this to an actual PR.

@aerorahul aerorahul marked this pull request as ready for review July 27, 2020 14:35
Copy link
Contributor

@mark-a-potts mark-a-potts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Worked with no problems on my generic linux box using GNU. My only question is whether we should have the ENABLE_TESTING default to ON instead of OFF.

@aerorahul
Copy link
Contributor Author

This looks good to me. Worked with no problems on my generic linux box using GNU. My only question is whether we should have the ENABLE_TESTING default to ON instead of OFF.

I was just keeping the defaults as other NCEPLIBS. @kgerheiser has the defaults to ENABLE_TESTS=OFF. A push and PR triggers tests on github.
I am happy to turn it ON, @kgerheiser?

Copy link
Collaborator

@jbathegit jbathegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, and thanks for integrating these into the build environment!

@aerorahul aerorahul merged commit 9f46582 into develop Jul 28, 2020
@aerorahul aerorahul deleted the feature/unit_tests branch July 28, 2020 19:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants