-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit_tests #11
add unit_tests #11
Conversation
Change-Id: Id74f6e9da78967d1c8261f0b6c35669a7fc1648b
Change-Id: I607151c32e0a8a1f3313cfc341d244a3c6028e21
Change-Id: Ia8c843c860df376b821d317d8f3cdce5ade5f0b9
Change-Id: I96ab6110eb7766e4d7ffe0c1a867d12f3213cb51
Change-Id: I353bd3986a01ad48f37948fa0bd75d17b9e1717e
… test data to the repo Change-Id: I898c3b8cf0bc4183d97239daee894c86ef9d7663
… test_out_3 cannot compile Change-Id: I76b13609113b65f22d53625b49f9da33ff73cc39
Change-Id: I1ee5482913731c8167d43c1c71e8722faa9c50b9
Change-Id: Ibfae1474d6ef1271b3c6fa8bbd5ab909a168860d
All the tests other than the _8 ones pass for me using both GNU and Intel on Hera. |
I think @jbathegit did not intend to run test the _8 library, but I may be wrong. |
Changing this to an actual PR. |
Change-Id: I7d687cc8122f758fe919e97a27a52c362c12f90e
This adds capability to fetch test data from ftp server. Change-Id: Iaee4828d369e189b9ea4be1fce499afdc537c439
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Worked with no problems on my generic linux box using GNU. My only question is whether we should have the ENABLE_TESTING default to ON instead of OFF.
I was just keeping the defaults as other NCEPLIBS. @kgerheiser has the defaults to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, and thanks for integrating these into the build environment!
This PR adds unit tests from @jbathegit .
c_hdr
were not available under build interface.README
is translated intoMarkdown
format.https://ftp.emc.ncep.noaa.gov/public/bufr.tar
.Testing:
Help wanted!
I cannot figure out why
test_OUT_3.f
won't compile with GNU and dynamic allocation.On Intel, the test compiles.
On Intel and GNU,
_8
tests exhibit failures. This will need careful look at the test codes itself.