Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (gnu) compiler option to allow argument mismatch. #179

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Add (gnu) compiler option to allow argument mismatch. #179

merged 1 commit into from
Sep 4, 2020

Conversation

DusanJovic-NOAA
Copy link
Contributor

gfortran 10.x treats argument mismatch as error

gfortran 10.x treats argument mismatch as error
@WenMeng-NOAA
Copy link
Collaborator

@mkavulich Please let me know your comments on this PR. Thanks!

@climbfuji
Copy link
Contributor

I can say that this is needed for compiling with gfortran-10 (@DusanJovic-NOAA got those flags from me)

@fossell
Copy link
Contributor

fossell commented Sep 4, 2020

This is fine with me. Do these need to be in release/public-v1 for MRW v1.1.0? Or is this separate development?

@climbfuji
Copy link
Contributor

This is fine with me. Do these need to be in release/public-v1 for MRW v1.1.0? Or is this separate development?

This is fine with me. Do these need to be in release/public-v1 for MRW v1.1.0? Or is this separate development?

We don't support gfortran-10 with MRW 1.1.0 (the model doesn't build with it either). But we need it in release/public-v2 for SRW 1.0.

@fossell
Copy link
Contributor

fossell commented Sep 4, 2020

@climbfuji - Ok great, glad it's not a last minute add to MRW. This can be merged into develop with Wen's approval and I can cherry pick it into release/public-v2. For future cmake mods that are needed for the SRW release, can we please submit them release/public-v2 directly? We will merge that back to develop eventually. Wen is quite busy with other merges lined up that need to go into develop, so to avoid delays in UFS development it would help if we route these through the release branches so our community team can act more quickly on them. Of course if there is some other reason people are using the develop branch and the cmake mods need to be in there quickly, just let me know.

@WenMeng-NOAA
Copy link
Collaborator

@climbfuji and @fossell Thanks for clarifying and reviewing this PR. I will merge it in develop soon.

@WenMeng-NOAA WenMeng-NOAA merged commit a060180 into NOAA-EMC:develop Sep 4, 2020
fossell pushed a commit to fossell/UPP that referenced this pull request Sep 4, 2020
gfortran 10.x treats argument mismatch as error
fossell added a commit that referenced this pull request Sep 4, 2020
Add (gnu) compiler option to allow argument mismatch. (#179)
WenMeng-NOAA added a commit that referenced this pull request Apr 19, 2021
* Add grib2 output tables for MRW/SRW to InputOutput documentation

* Include a variety of examples for regridding instead of a single generic example

* Minor mod to Acknowledgments

* Replace cld_amt, the 3D cloud fraction from the GFDL mp with the same field for all (#170)

microphysics schemes, cldfra.

* Add (gnu) compiler option to allow argument mismatch. (#179)

gfortran 10.x treats argument mismatch as error

* Change control files names fv3sar->fv3lam to be in-line with SRW release

* Change flat file names fv3sar->fv3lam

* Updated support on Odin & Stampede to use NCEPLIBS public-v2 release

* Change executable name of cmake build for public-v2 to be ncep_post, consistent with other applications

* Update submodule pointer for CMakeModules to fix linker problem against static NetCDF libraries

* Starting UPP version numbers with 10.0.0 for develop branch

* Starting release/public-v2 branch with UPP version 9.0.0

* Remove old community build libraries and gnu make utilities

* Remove configure/compile/clean utilties for old community build

* Modified UPP stand-alone run script with name change to run_upp

* Bug fix for FV3 LAM/LAMX (#219)

* Fix of total cloud fraction in CLDRAD.f for FV3/LAMX.

* Setting  iSF_SURFACE_PHYSICS as 2 in regional FV3 read interface.

* Add/modify RST documentation files for UPP release/public-v2

* Remove Hera GNU from list of supported platforms

* Add link to external wiki page listing NCEPLIBS locations on pre-configured machines

* Adding advanced documentation on how to add a new variable

* modify User Support link and data download link

* Update wgrib2 output, links to grib table descriptions

* Try inter-chapter link

* Another inter-chapter link attempt

* Need autosectionlabel extension for this to work

* Various spelling and format fixes in InputsOutputs

* Minor updates to Installation chapter

* Some more minor changes

* Update CMakeModules

* remove duplicate cldfra variable accidently added in merge

* Documentation updates for GNU version and minor syntax fix.

* Revert module files for Odin and Stampede per ywangwof since build env is handled at app level for these machines

* remove extraneous conflict HEAD line

Co-authored-by: Tracy <hertneky@ucar.edu>
Co-authored-by: ericaligo-NOAA <48365233+ericaligo-NOAA@users.noreply.github.com>
Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
Co-authored-by: Yunheng Wang <yunheng.wang@noaa.gov>
Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>
Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants