Bug fix for FV3 LAM/LAMX #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericaligo-NOAA - Should this bug fix be going into the release/public-v2 branch as well for SRW release? |
|
@fossell These are two bug fixes for regional FV3. Please sync in release/public-v2. |
@WenMeng-NOAA Thanks, I'll cherry pick this into public-v2 once merged into develop. |
|
The regression tests were conducted on Dell, Cray and Hera. With this PR, the baseline for FV3 LAM will be re-created. The FV3 LAM developer tested and verified the changes. |
|
This PR is ready for merging. |
fossell
pushed a commit
to fossell/UPP
that referenced
this pull request
Nov 10, 2020
* Fix of total cloud fraction in CLDRAD.f for FV3/LAMX. * Setting iSF_SURFACE_PHYSICS as 2 in regional FV3 read interface.
fossell
added a commit
that referenced
this pull request
Nov 10, 2020
Bug fix for FV3 LAM/LAMX (#219)
JesseMeng-NOAA
pushed a commit
to JesseMeng-NOAA/UPP
that referenced
this pull request
Nov 13, 2020
WenMeng-NOAA
pushed a commit
that referenced
this pull request
Dec 29, 2020
* 20200820 Jesse Meng refactor branch of remove goto remove grib1 * 20200901 Jesse Meng remove redundant LAI output in SURFCE.f * 20200901 Jesse Meng continue merging refactor to develop * 20200911 Jesse Meng add precisions to selected variables * 20200911 Jesse Meng revert the precision changes * 20200924 Jesse Meng update with EMC_post/develop * 20201105 Jesse Meng merge with NOAA-EMC/EMC_post PR#196 eed90f5 * 20201105 Jesse Meng sync with EMC_POST/develop * 20201106 Jesse Meng add module UPP_MATH * 20201113 Jesse Meng add UPP_MATH and UPP_PHYSICS modules and updated with #219 * 20201113 Jesse Meng updated CMakeLists.txt with EMC_post/develop * 20201113 Jesse Meng fix sorc/ncep_post.fd/CMakeLists.txt for added/removed files * 20201130 Jesse Meng update modules, move GRIDAVG.f inside module UPP_MATH * 20201215 Jesse Meng fix EXCH() options in CALVOR and UPP_MATH * 20201215 Jesse Meng merge with EMC_post/develop * 20201215 Jesse Meng minor clean up as suggested by reviewers * 20201218 Jesse Meng revised RH unification fv3, fv3r, nmmb, use CALRH_NAM hrrr, rap, use CALRH_GSD * 20201222 Jesse Meng convert UPP_MATH UPP_PHYSICS docblocks to doxygen format * 20201223 Jesse Meng minor revision style tweaking * 20201223 Jesse Meng fix redundance which costs nmmb runtime Co-authored-by: wx22mj <Jesse.Meng@m71a1.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@m71a3.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@v71a1.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@m71a2.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@m72a1.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@v71a3.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@v72a1.ncep.noaa.gov>
WenMeng-NOAA
added a commit
that referenced
this pull request
Apr 19, 2021
* Add grib2 output tables for MRW/SRW to InputOutput documentation * Include a variety of examples for regridding instead of a single generic example * Minor mod to Acknowledgments * Replace cld_amt, the 3D cloud fraction from the GFDL mp with the same field for all (#170) microphysics schemes, cldfra. * Add (gnu) compiler option to allow argument mismatch. (#179) gfortran 10.x treats argument mismatch as error * Change control files names fv3sar->fv3lam to be in-line with SRW release * Change flat file names fv3sar->fv3lam * Updated support on Odin & Stampede to use NCEPLIBS public-v2 release * Change executable name of cmake build for public-v2 to be ncep_post, consistent with other applications * Update submodule pointer for CMakeModules to fix linker problem against static NetCDF libraries * Starting UPP version numbers with 10.0.0 for develop branch * Starting release/public-v2 branch with UPP version 9.0.0 * Remove old community build libraries and gnu make utilities * Remove configure/compile/clean utilties for old community build * Modified UPP stand-alone run script with name change to run_upp * Bug fix for FV3 LAM/LAMX (#219) * Fix of total cloud fraction in CLDRAD.f for FV3/LAMX. * Setting iSF_SURFACE_PHYSICS as 2 in regional FV3 read interface. * Add/modify RST documentation files for UPP release/public-v2 * Remove Hera GNU from list of supported platforms * Add link to external wiki page listing NCEPLIBS locations on pre-configured machines * Adding advanced documentation on how to add a new variable * modify User Support link and data download link * Update wgrib2 output, links to grib table descriptions * Try inter-chapter link * Another inter-chapter link attempt * Need autosectionlabel extension for this to work * Various spelling and format fixes in InputsOutputs * Minor updates to Installation chapter * Some more minor changes * Update CMakeModules * remove duplicate cldfra variable accidently added in merge * Documentation updates for GNU version and minor syntax fix. * Revert module files for Odin and Stampede per ywangwof since build env is handled at app level for these machines * remove extraneous conflict HEAD line Co-authored-by: Tracy <hertneky@ucar.edu> Co-authored-by: ericaligo-NOAA <48365233+ericaligo-NOAA@users.noreply.github.com> Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Yunheng Wang <yunheng.wang@noaa.gov> Co-authored-by: Dom Heinzeller <climbfuji@ymail.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
change CLWMR -> CLMR in the postxconfig-NT file to match the latest GIB2 table Use the halo4 mosaic file (c3445_mosaic.halo4.nc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes: