UPP refactor phase 2 from Jesse Meng #224
Conversation
Merge remote-tracking branch 'upstream/develop' into develop
|
@JesseMeng-NOAA The commit log in your branch feature/post_refactor_p2 look not right to me. I don't see some recent PRs after 196. You may use the procedure to sync your feature branch at |
|
Merged with EMC_post/develop.
==============================================
Dr. Jesse Meng
IMSG at NOAA/NWS/NCEP/EMC
5830 University Research Ct. Room 2037
College Park, MD 20740
email: jesse.meng@noaa.gov
==============================================
…On Fri, Nov 13, 2020 at 4:12 PM WenMeng-NOAA ***@***.***> wrote:
@JesseMeng-NOAA <https://github.com/JesseMeng-NOAA> The commit log in
your branch feature/post_refactor_p2 look not right to me. I don't see some
recent PRs after 196. You may use the procedure to sync your feature branch
at
https://github.com/NOAA-EMC/EMC_post/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-original-repository
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#224 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALXNRCO2C53WITBYCUIUCRLSPWOKDANCNFSM4TU6OMIA>
.
|
|
@JesseMeng-NOAA Now the commit log look good to me. Thanks! |
|
@fossell I know you will take leave soon. Will you recommend some one from the DTC team to review this PR? Should we |
|
@JesseMeng-NOAA Please sync your branch with the latest changes from upstream/develop again. |
…nto feature/post_refactor_p2
|
https://github.com/JesseMeng-NOAA/EMC_post/tree/feature/post_refactor_p2 |
|
@JesseMeng-NOAA The merging is in blocked status. Please check any conflicts in your branch and solve them. |
Updated. Also convert UPP_MATH UPP_PHYSICS docblocks to doxygen format. |
sorc/ncep_post.fd/UPP_MATH.f
Outdated
| !! MAY 20 2020 Jesse Meng Initial code | ||
| !!------------------------------------------------------------------------ | ||
| !! | ||
| MODULE UPP_MATH |
There was a problem hiding this comment.
@JesseMeng-NOAA lower case format.
|
@mkavulich Does the current version meet your change request from code review? |
|
@JesseMeng-NOAA Should I expect new commit in your branch for those minor tweaking to do final tests? |
Yes I will commit all at once when you done with current review. Let me know. |
Good. Let me know when the new commit is ready. I will conduct the final tests across platforms. |
|
@JesseMeng-NOAA The current version is good to me. Please commit changes for code style tweaking. |
|
@JesseMeng-NOAA The nmmb tests on Hera show runtime slow 6 times and more. Do you have any explanation for that change? |
|
Not sure. I can try to diagnose it.
…On Wednesday, December 23, 2020, WenMeng-NOAA ***@***.***> wrote:
@JesseMeng-NOAA <https://github.com/JesseMeng-NOAA> The nmmb tests on
Hera show runtime slow 6 times and more. Do you have any explanation for
that change?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#224 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALXNRCOYTLVI4N3WLQVFUNLSWI5AZANCNFSM4TU6OMIA>
.
--
==============================================
Dr. Jesse Meng
IMSG at NOAA/NWS/NCEP/EMC
5830 University Research Ct. Room 2037
College Park, MD 20740
email: jesse.meng@noaa.gov
==============================================
|
Fixed. |
Great! I will start the final tests. |
|
The regression tests were finished on Dell, Cray and Hera. New baseline will be created for gfs, gefs, fv3r. |
|
Looks good to me, thank you for making the requested changes. |
|
Thanks for Jesse and all code reviewers. This PR is ready for merging. |
|
The baselines for gfs, gefs, fv3r will be recreated. |
Refactor phase 2 adding UPP_MATH and UPP_PHYSICS modules