Update Documentation for GFSPOSTSIG.F #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fossell
approved these changes
Mar 16, 2023
|
@FernandoAndrade-NOAA Can you conduct the RT tests either on Hera or Orion? We do not expect changed results from this PR. Thanks! |
|
@WenMeng-NOAA apologies for the delayed reply, I have the RT tests running on Hera and Orion, I'll update again when they finish with the results. |
|
Tests have completed Hera and Orion with no changes to results. |
FernandoAndrade-NOAA
approved these changes
Mar 16, 2023
|
The UPP RT tests were completed on WCOSS2 with no changed results. This PR is ready for merging. |
WenMeng-NOAA
approved these changes
Mar 17, 2023
WenMeng-NOAA
added
Ready for Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates GFSPOSTSIG.F so that warnings do not appear in Doxygen. It does not provide definitions for all missing variables based on @WenMeng-NOAA 's feedback that this file's functionality will be phased out in the near future, and complete documentation of definitions is therefore not worthwhile.
This PR partially addresses Issue #392 .