Eliminate negative probabilities in IFI_PROB after hour 25.454545...

[SamuelTrahanNOAA]

When the post is compiled with libIFI and asked to generate icing probabilities, times after hour 25.454545... generate invalid data. This PR does two things:

1. Fixes the bug in libIFI that causes this. (fabs(ICE_PROB) > epsilon should be ICE_PROB > epsilon)
2. Has the post output missing data for all IFI fields at hour 0 and after hour 18.

There is also a minor refactoring of the IFI.F to avoid having two routines that write missing data for IFI.

Closes issue #709

[WenMeng-NOAA]

@SamuelTrahanNOAA Can you open an UPP issue linking to this PR?

[SamuelTrahanNOAA]

Can you open an UPP issue linking to this PR?

It is now issue #709

[SamuelTrahanNOAA]

The RRFS developers have been waiting for this for two weeks, so if it could be prioritized a bit higher, then we'd all sleep better.

[WenMeng-NOAA]

The RRFS developers have been waiting for this for two weeks, so if it could be prioritized a bit higher, then we'd all sleep better.

Sure. I will set it as the higher priority for processing. @SamuelTrahanNOAA

[WenMeng-NOAA]

@SamuelTrahanNOAA Can you sync your branch with the latest UPP develop branch?

[SamuelTrahanNOAA]

Can you sync your branch with the latest UPP develop branch?

I have done so.

[WenMeng-NOAA]

The UPP RT tests were completed on WCOSS2 without changed results.

[WenMeng-NOAA]

@FernandoAndrade-NOAA Please conduct the RT tests on Hera and Orion.

[WenMeng-NOAA]

@SamuelTrahanNOAA I assume that you already updated the external IFI lib on Hera at /scratch2/BMC/ifi/modulefiles/ifi/20230511-intel-2022.1.2, right?

[SamuelTrahanNOAA]

I assume that you already updated the external IFI lib on Hera at /scratch2/BMC/ifi/modulefiles/ifi/20230511-intel-2022.1.2, right?

The modulefiles now match the right IFI version on Jet, Hera, and Acorn.

[WenMeng-NOAA]

I assume that you already updated the external IFI lib on Hera at /scratch2/BMC/ifi/modulefiles/ifi/20230511-intel-2022.1.2, right?

The modulefiles now match the right IFI version on Jet, Hera, and Acorn.

@SamuelTrahanNOAA I was able to generate IFI products on Hera via internal and external IFI building.

[SamuelTrahanNOAA]

I was able to generate IFI products on Hera via internal and external IFI building.

That sounds like a positive sign.

[FernandoAndrade-NOAA]

RTs completed on Hera with no changes to results. Orion test results showed changes in rtma and gfs, but I don't believe to be a result of this PR as I've seen them last week as well. @WenMeng-NOAA

[WenMeng-NOAA]

RTs completed on Hera with no changes to results. Orion test results showed changes in rtma and gfs, but I don't believe to be a result of this PR as I've seen them last week as well. @WenMeng-NOAA

It seems the changes of simulated satellite products for GFS and 3DRTMA on Orion might be related to updates of crtm fix files at EPIC-stack. I recreated the baseline of GFS and 3DRTMA in the RT test package. The RT testing was successfully completed on Orion now.

[WenMeng-NOAA]

This PR is ready for merging.