Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same real kind for axis variables in restart files as real kind used for data variables. #697

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Sep 13, 2023

Description

This PR updates io routines to use the same data type (float or double) for axes in restart files as data type used for data variables. This will make a temporary fix in restart write routine in the write grid component unnecessary and make everything consistent and restart files written by FMS and write grid component will be identical.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested? Yes
What compilers / HPCs was it tested with? Intel and GNU on Hera
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? Yes, all tests that write restart files will need new baselines
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA cubed sphere pr was merged. Can you update hash and revert change in gitmodules ?

@jkbk2004 jkbk2004 merged commit 3b4423c into NOAA-EMC:develop Sep 26, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the axis_type branch September 27, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent data types used for axes and variables in restart files
3 participants