Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write netcdf axis variables using the same real kind as data variables #283

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

DusanJovic-NOAA
Copy link
Contributor

Description

Currently, the axis data type in restart files is always "double" regardless of the data type (float vs. double) of used for data variables. This PR updates io routines so that axis data type corresponds to the actual precision used for data variables.
This change is necessary to make restart files bit-identical to the restart files written out by the write grid component in UFS weather model.

Fixes # (issue)
NOAA-EMC/fv3atm#696

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Full regression test of the ufs weather model passed on Hera (both Intel and GNU compilers) and Orion.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@jkbk2004
Copy link

@laurenchilutti All tests are done at ufs-community/ufs-weather-model#1903. Please, go ahead to merge this pr.

@laurenchilutti laurenchilutti merged commit 9616e4e into NOAA-GFDL:dev/emc Sep 26, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the axis_type branch September 26, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants