Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring j-jobs up to EE2 compliance. #1069

Open
aerorahul opened this issue Oct 12, 2022 · 2 comments
Open

Bring j-jobs up to EE2 compliance. #1069

aerorahul opened this issue Oct 12, 2022 · 2 comments
Labels

Comments

@aerorahul
Copy link
Contributor

Description
Several j-jobs within the global-workflow do not adhere to EE2 standards and compliance.
Moreover, several tasks have j-jobs missing. All tasks within the global-workflow should adhere to EE2 standards, regardless of them being part of an operational system.

Requirements
j-jobs should adhere EE2 implementation standards available here

Acceptance Criteria (Definition of Done)
j-jobs follow implementation standards guidelines.

@aerorahul
Copy link
Contributor Author

Some work was performed and merged via PR's #1120 and #1176
More work is required to add j-jobs to jobs that are not currently in operations, but should conform to EE2 standards.

@aerorahul aerorahul added this to the GFSv17 milestone Dec 23, 2022
@WalterKolczynski-NOAA
Copy link
Contributor

#1223 and #1226 are related to this

WalterKolczynski-NOAA added a commit that referenced this issue Jan 14, 2023
Takes all of the tasks that are common to all j-jobs and abstracts them out into a shared script that is sourced by each job:
- Set and create $DATA directory
- Call setpy and set $cycle
- Set pid, pgmout, and pgmerr
- Source config files
- Source machine environment file

The common j-job header script is called by passing the job name for the `${machine}.env` files using the `-e` option, and a list of config files to source with the `-c` option.
```
${HOMEgfs}/ush/jjob_header.sh -e [env_job] -c "[config1 [config2 [...]]]"
```
The job name argument (`-e`) is mandatory, and the config list is optional but recommend to always use as well.

Some pre j-job rocoto entry scripts (`jobs/rocoto/*`) are currently doing much more than they should be. These sometimes required extra finagling, usually pre-calling the jjob header in the rocoto script before it does something.

Refs: #1069
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed this from the GFSv17 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants