Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in ush/forecast_det.sh #1185

Closed
XianwuXue-NOAA opened this issue Dec 16, 2022 · 0 comments · Fixed by #1186
Closed

Fix a bug in ush/forecast_det.sh #1185

XianwuXue-NOAA opened this issue Dec 16, 2022 · 0 comments · Fixed by #1186
Assignees
@XianwuXue-NOAA
Labels
bug Something isn't working

Comments

@XianwuXue-NOAA
Copy link
Contributor

Expected behavior

The workflow can run forecast jobs for gdas

Current behavior

When I run gdasfcst and gdasefmn jobs, they will fail because filecount: unbound variable in ush/forecast_det.sh: line 44

Machines affected

WCOSS2

To Reproduce

Run gdas or early enkf using the latest develop branch

Detailed Description

lfs/h2/emc/ens/noscrub/xianwu.xue/GEFS_v13_da/gw_gefs_da/scripts/../ush/forecast_det.sh: line 44: filecount: unbound variable
@XianwuXue-NOAA XianwuXue-NOAA added the bug Something isn't working label Dec 16, 2022
@XianwuXue-NOAA XianwuXue-NOAA self-assigned this Dec 16, 2022
XianwuXue-NOAA added a commit to XianwuXue-NOAA/global-workflow that referenced this issue Dec 16, 2022
@XianwuXue-NOAA
Fix a bug for running fcst jobs for gdas
398a3cf 
 On branch hotfix/fix_forecast_det_1185
	modified:   ush/forecast_det.sh

Refs: NOAA-EMC#1185
@XianwuXue-NOAA XianwuXue-NOAA mentioned this issue Dec 16, 2022
Merged
7 tasks
XianwuXue-NOAA added a commit to XianwuXue-NOAA/global-workflow that referenced this issue Dec 16, 2022
@XianwuXue-NOAA
Improve the statement
cc311e3 
 On branch hotfix/fix_forecast_det_1185
	modified:   ush/forecast_det.sh

Refs: NOAA-EMC#1185
WalterKolczynski-NOAA pushed a commit that referenced this issue Dec 18, 2022
@XianwuXue-NOAA
Fix checking for restart files (#1186)
8581eac 
Undoes the portion of PR #1179 that caused a new bug while attempting to fix #1140, without removing the linter fixes. Instead `/dev/null` is 'searched' if `${RSTDIR_ATM}` is not defined. That situation will always result in zero files found, ensuring a rerun is not triggered.

Fixes #1140 
Fixes #1185
Moots #1190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XianwuXue-NOAA XianwuXue-NOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix checking for restart files XianwuXue-NOAA/global-workflow
1 participant
@XianwuXue-NOAA