Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect and misleading comments in config.base #1260

Closed
KateFriedman-NOAA opened this issue Jan 20, 2023 · 0 comments · Fixed by #1261
Closed

Remove incorrect and misleading comments in config.base #1260

KateFriedman-NOAA opened this issue Jan 20, 2023 · 0 comments · Fixed by #1261
Assignees
Labels
bug Something isn't working

Comments

@KateFriedman-NOAA
Copy link
Member

Expected behavior

Comments should be correct and not misleading, particularly for new users.

Current behavior

A comment block in config.base.emc.dyn and config.base.nco.static currently mentions an OUTPUT_GRID we do not support (cubed_sphere_grid) and can mislead users to change OUTPUT_GRID away from the default of gaussian_grid, which causes forecast job failures (e.g. in APP=ATM forecast-only mode at least) when the incorrect diag_table is used.

Error in gfsfcst.log:

 21: FATAL from PE    21: diag_util_mod::init_output_field: file fv3_history2d is NOT found in the diag_table

When export OUTPUT_GRID=cubed_sphere_grid is set config.fcst sets a diag_table that doesn't work:

+++ config.fcst[319]: export DIAG_TABLE=/scratch1/NCEPDEV/global/Nick.Szapiro/global/global-workflow/parm/parm_fv3diag/diag_table_orig

Machines affected

All, machine agnostic.

To Reproduce

Set up an out-of-the-box forecast-only test and change OUTPUT_GRID to "cubed_sphere_grid".

Detailed Description

Remove the following comments in both config.base versions to remove the incorrect and misleading details:

# I/O QUILTING, true--use Write Component; false--use GFDL FMS
# if quilting=true, choose OUTPUT_GRID as cubed_sphere_grid in netcdf
# if gaussian_grid, set OUTPUT_FILE for netcdf
@KateFriedman-NOAA KateFriedman-NOAA added the bug Something isn't working label Jan 20, 2023
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Jan 20, 2023
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jan 20, 2023
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jan 20, 2023
KateFriedman-NOAA added a commit that referenced this issue Jan 20, 2023
Remove incorrect comments in config.base.emc.dyn and config.base.nco.static

Refs #1260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant