Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Exception Handling Issue Found in build_all.sh #14

Closed
lgannoaa opened this issue Jan 24, 2020 · 10 comments
Closed

Fix Exception Handling Issue Found in build_all.sh #14

lgannoaa opened this issue Jan 24, 2020 · 10 comments
Assignees
@lgannoaa
Labels
feature New feature or request

Comments

@lgannoaa
Copy link
Contributor

Arun assigned Lin to fix the exception handling issues found in build_all.sh.
@lgannoaa lgannoaa changed the title Fix Execuption Handling Issue Found in build_all.sh Fix Exception Handling Issue Found in build_all.sh Jan 24, 2020
@KateFriedman-NOAA KateFriedman-NOAA added the feature New feature or request label Jan 24, 2020
@lgannoaa
Copy link
Contributor Author

Implement exception handling in build_all.sh. Tested in Dell, Hera, and Cray. This improved solution will identify building error and handle exception by fail in proper message.

@KateFriedman-NOAA
Copy link
Member

Pull request initiated: #15

@KateFriedman-NOAA
Copy link
Member

Cancelled prior pull request after request for additional changes to script. Retested after modifications were made and the changes looked good.

@lgannoaa Are you ready to do the pull request again? Any further changes to make or tests to do? @EricRogers-NOAA @arunchawla-NOAA @Hang-Lei-NOAA any further feedback on the changes Lin made to build_all.sh?

@arunchawla-NOAA
Copy link
Contributor

arunchawla-NOAA commented Feb 6, 2020 via email

@Hang-Lei-NOAA
Copy link
Contributor

Hang-Lei-NOAA commented Feb 6, 2020 via email

@EricRogers-NOAA
Copy link

I agree with Arun and Hang.
Eric

@lgannoaa
Copy link
Contributor Author

lgannoaa commented Feb 6, 2020

PR is done. Thanks everyone :-)

@KateFriedman-NOAA
Copy link
Member

KateFriedman-NOAA commented Feb 6, 2020 via email

@KateFriedman-NOAA
Copy link
Member

Submitting PR.

@KateFriedman-NOAA
Copy link
Member

PR #18 submitted and committed to develop branch. Closing ticket now. Thanks @lgannoaa !

zhanglikate added a commit to zhanglikate/global-workflow that referenced this issue Oct 26, 2020
@zhanglikate
Merge pull request NOAA-EMC#14 from jkhender/feature/chem
aac68dc 
Feature/chem
WalterKolczynski-NOAA added a commit that referenced this issue Oct 8, 2021
@WalterKolczynski-NOAA
Convert rocoto_viewer for python3
57748d5 
The rocoto_viewer script is updated to python3. In addition to making
the necessary syntax updates like converting print statements into
print functions (adding parentheses), this requried removing the
dependency on produtils scripts (which are still in python2). This
change will also make the script more portable.

The largest chunk of changes to remove produtils revolves around
making system calls to run rocoto. These are replaced with a simple
wrapper function that calls subprocess, captures the output, and
returns it as a string. This also allows for the streamlining of
these portions of code.

A fallback is added in case lxml is not available. This will only
cause problems if lxml is not available and the user tries to read
a workflow that uses external entities, in which case a message
will be displayed notifying the user of the issue and providing
instructions on how to install lxml with pip. A similar existing
message for dateutil (used for UGCS's monthly increment) was
updated similarly.

Some incidental syntax updating and unused variable removal was
done as they were encountered, but a more complete cleaning of these
is still needed.

Refs: #13, #14
WalterKolczynski-NOAA added a commit that referenced this issue Oct 8, 2021
@WalterKolczynski-NOAA
Remove string modulo and fix assorted bugs in rocoto_viewer
f1c5f71 
All strings still using the modulo (%) operator for substitution
are replaced with more readable f-strings instead.

Some remaining instances that were using functions from produtil
that were missed in the previous commit are updated to replace
those functions. Two functions for validating a POSIX shell string
are copied and updated from produtil for use here.

Some minor bugs and typos are resolved.

Replaced the former cPickle (which is not available for python3)
calls with pickle calls.

Fixed bugs in rocotocheck related to passing an int argument instead
of a string to syscall and not defining current_check_time.

Corrected issue with rocoto_viewer not immediately exiting when the
workflow cannot be parsed (usually because lxml could not be loaded).

Refs: #13, #14
lgannoaa pushed a commit to lgannoaa/global-workflow that referenced this issue Feb 9, 2022
@ywangwof @WenMeng-NOAA
Added lambert conformal projection for FV3SAR and handled composite r…
b78469b 
…eflectivity correctly (NOAA-EMC#14)
zhanglikate pushed a commit to zhanglikate/global-workflow that referenced this issue Oct 6, 2022
@DusanJovic-NOAA
Add support for cmake build system (NOAA-EMC#14)
3bc41ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgannoaa lgannoaa

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lgannoaa @KateFriedman-NOAA @Hang-Lei-NOAA @EricRogers-NOAA @arunchawla-NOAA