-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using stand-alone UPP #2437
Comments
FYI @WenMeng-NOAA |
@JessicaMeixner-NOAA @WalterKolczynski-NOAA I have been preparing my UFS PR for updating upp submodule. |
@WalterKolczynski-NOAA and @WenMeng-NOAA: I assume from this issue that ~HOMEgfs/sorc/upp.fd is the stand-alone UPP. Execution of
A check of
CI testing using C96C48_hybatmDA and C96C48_ufs_hybatmDA encounter failed jobs for gdasatmanlupp and gfsatmanlupp because It this failure expected? |
The failure is not expected from a fresh clone. If you tried to pull in develop to an existing clone, you should've gotten a warning about it couldn't overwrite the upp.fd symlink. If that is the case, delete the symlink and then pull again (recursively or run submodule update afterwards). |
Manually remove |
@WalterKolczynski-NOAA @aerorahul The ufs-weather-model PR #2213 was submitted for updating upp submodule. |
@WenMeng-NOAA thanks for keeping us updated. First time we updated UFS after that is merged we can remove the temporary submodule. |
I got the same error on Hera (Rocky8) and the manual method did not work for me.
I started from a clean recursive clone. I tried twice but got the same error. Here are the steps I repeat the error:
Could this be related to any of my environment settings? |
@guoqing-noaa we found there is actually an issue with the UPP hash. We added the fix into #2442, which should be merged soon. |
@WalterKolczynski-NOAA My UFS PR #2213 was merged today. You may update the global-workflow accordingly to solve this issue. |
Updates ufs-weather-model, this updates RDHPCS to the newer spack-stack allowing some temporary fixes to be reverted. * removes upp submodule * uses upp from the ufs-weather-model * restores the build and link that were hacked during the Hera Rocky 8 transition to allow for UPP submodule * Removes forecast directories in clean-up Resolves #2617 Resolves #2437 --------- Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
What new functionality do you need?
As part of the Rocky 8 upgrade for Hera (PR #2421), we had to move to a stand-alone UPP version because the one in UFS has not yet been updated. Once the UPP version in UFS is updated to include the Rocky 8 updates, we should move back to using that version instead of checking out a separate version.
What are the requirements for the new functionality?
No separate UPP submodule
Acceptance Criteria
Dependency: ufs-community/ufs-weather-model#2213
ufs_model.fd/FV3/upp/tests
instead ofupp.fd/tests
ufs_model.fd/FV3/upp
tosorc/upp.fd
inlink_workflow.sh
Suggest a solution (optional)
No response
The text was updated successfully, but these errors were encountered: