Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip GFS and GEFS default builds for waves #2461

Closed
aerorahul opened this issue Apr 5, 2024 · 0 comments · Fixed by #2462
Closed

Flip GFS and GEFS default builds for waves #2461

aerorahul opened this issue Apr 5, 2024 · 0 comments · Fixed by #2462
Labels
feature New feature or request

Comments

@aerorahul
Copy link
Contributor

What new functionality do you need?

./build_all.sh builds the ufs-weather-model with waves configured with a structured grid. This is a requirement for GFSv17.
To build the ufs-weather-model with with configured with unstructured grid, an argument -w needs to be passed to build_all.sh.

This is often overlooked by developers and results in the model hanging for GFS configurations.

This feature requests flipping the -w switch where -w would build the ufs-weather-model with a structured grid.

What are the requirements for the new functionality?

No additional requirements than what is already there.

Acceptance Criteria

  • Updated documentation
  • Passing tests for GFS and GEFS

Suggest a solution (optional)

No response
@aerorahul aerorahul added feature New feature or request triage Issues that are triage and removed triage Issues that are triage labels Apr 5, 2024
@aerorahul aerorahul mentioned this issue Apr 5, 2024
Merged
7 tasks
aerorahul added a commit that referenced this issue Apr 8, 2024
@aerorahul
Flip the build for GFS and GEFS with waves (#2462)
0237dba 
This PR:
- builds the unstructured waves as default when invoked with
`build_all.sh`.
- updates the CI testing infrastructure to handle this change.
- updates the documentation to reflect this change in behaviour.

To build with structured grid for waves, the flag `-w` needs to be
passed to `./build_all.sh`. Previously, this would trigger the
unstructured grid. Since GFSv17 will move to unstructured grid as
default for waves, this makes it easier for a majority of developers.

Resolves #2461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flip the build for GFS and GEFS with waves aerorahul/global-workflow
1 participant
@aerorahul