Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move workflow utils into their own directory #356

Closed
WalterKolczynski-NOAA opened this issue Jun 23, 2021 · 0 comments
Closed

Move workflow utils into their own directory #356

WalterKolczynski-NOAA opened this issue Jun 23, 2021 · 0 comments
Assignees
@WalterKolczynski-NOAA
Labels
coupled Issues related to the coupled branch feature New feature or request uncoupled Issues related to the uncoupled system

Comments

@WalterKolczynski-NOAA
Copy link
Contributor

Since the workflow utils are now being built as a single package using cmake, it would be nice to move all the directories into a single directory (or maybe their own repo) to clean up sorc a bit.
@WalterKolczynski-NOAA WalterKolczynski-NOAA added feature New feature or request coupled Issues related to the coupled branch uncoupled Issues related to the uncoupled system duplicate This issue or pull request already exists and removed coupled Issues related to the coupled branch duplicate This issue or pull request already exists labels Jun 23, 2021
WalterKolczynski-NOAA added a commit that referenced this issue Dec 17, 2021
@WalterKolczynski-NOAA
Move source code to new repository
eaabdb0 
Directories in sorc and util containing source code are removed.
These have been moved to a new repository, global-workflow-utils,
that will hold all code managed by the global team. A new checkout
entry has been added that clones that repository.

Some adjustments still need to be made before the programs can be
built.

Refs: #356
@WalterKolczynski-NOAA WalterKolczynski-NOAA self-assigned this Aug 29, 2022
@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title Move workflow utils into their own directory (repo?) Move workflow utils into their own directory Aug 29, 2022
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Aug 31, 2022
@WalterKolczynski-NOAA
Remove gfs-utils code and update for new fix
f1c74b1 
Removes all of the code and scripts that were moved to the new gfs-utils
repo and adjusts workflow scripts to build and use them from the new
location.

Some of the build scripts had unnecessary calls to machine-setup that are
removed because the lower-level script already has the same functionality.

This PR also includes updates to use the new fix organization. This includes
the addition of a fix versions file, updates to the link script, and some
changes in the fix directories used by scripts to account for files that
have been relocated. The versions file sets the version number for each
component of fix, so that fix can be more easily maintained and documented.
The initial versions are all the same, and correspond to the old fix_NEW
directory (other than some directories have been renamed or reorganizated).

Finally, the link script has been updated to match the syntax of the rest
of the build system (`checkout.sh` and `build_all.sh`). `link_workflow.sh`
now detects the machine automatically instead of requiring an argument, and
dev mode, which used to be set using `emc` as an argument, is now assumed.
To run in ops mode (copy instead of link), the `-o` option is used. The
full syntax is now simply:
```
./link_workflow.sh [-o]

-o: Run in operations (NCO) mode (copy instead of link)
```

This commit uses a temporary clone of the UFS_UTILS repo pending the merger
of ufs-community/UFS_UTILS#688.

Fixes NOAA-EMC#356
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Aug 31, 2022
@WalterKolczynski-NOAA
Remove gfs-utils code and update for new fix
91c9ef4 
Removes all of the code and scripts that were moved to the new gfs-utils
repo and adjusts workflow scripts to build and use them from the new
location.

Some of the build scripts had unnecessary calls to machine-setup that are
removed because the lower-level script already has the same functionality.

This PR also includes updates to use the new fix organization. This includes
the addition of a fix versions file, updates to the link script, and some
changes in the fix directories used by scripts to account for files that
have been relocated. The versions file sets the version number for each
component of fix, so that fix can be more easily maintained and documented.
The initial versions are all the same, and correspond to the old fix_NEW
directory (other than some directories have been renamed or reorganizated).

Finally, the link script has been updated to match the syntax of the rest
of the build system (`checkout.sh` and `build_all.sh`). `link_workflow.sh`
now detects the machine automatically instead of requiring an argument, and
dev mode, which used to be set using `emc` as an argument, is now assumed.
To run in ops mode (copy instead of link), the `-o` option is used. The
full syntax is now simply:
```
./link_workflow.sh [-o]

-o: Run in operations (NCO) mode (copy instead of link)
```

This commit uses a temporary clone of the UFS_UTILS repo pending the merger
of ufs-community/UFS_UTILS#688.

Fixes NOAA-EMC#356
Merged
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Aug 31, 2022
@WalterKolczynski-NOAA
Correct merge error in link script
d4fb0f7 
An incorrect resolution of a merge conflict resulted in an undefined
variable in the link script.

Refs: NOAA-EMC#356
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Sep 27, 2022
@WalterKolczynski-NOAA
Fix default missing var syntax error
77b9582 
Corrects a `:-?` to `:?`.

Refs: NOAA-EMC#356
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Oct 4, 2022
@WalterKolczynski-NOAA
Remove gfs-utils code and update for new fix
18a599a 
Removes all of the code and scripts that were moved to the new gfs-utils
repo and adjusts workflow scripts to build and use them from the new
location.

Some of the build scripts had unnecessary calls to machine-setup that are
removed because the lower-level script already has the same functionality.

This PR also includes updates to use the new fix organization. This includes
the addition of a fix versions file, updates to the link script, and some
changes in the fix directories used by scripts to account for files that
have been relocated. The versions file sets the version number for each
component of fix, so that fix can be more easily maintained and documented.
The initial versions are all the same, and correspond to the old fix_NEW
directory (other than some directories have been renamed or reorganizated).

Finally, the link script has been updated to match the syntax of the rest
of the build system (`checkout.sh` and `build_all.sh`). `link_workflow.sh`
now detects the machine automatically instead of requiring an argument, and
dev mode, which used to be set using `emc` as an argument, is now assumed.
To run in ops mode (copy instead of link), the `-o` option is used. The
full syntax is now simply:
```
./link_workflow.sh [-o]

-o: Run in operations (NCO) mode (copy instead of link)
```

This commit uses a temporary clone of the UFS_UTILS repo pending the merger
of ufs-community/UFS_UTILS#688.

Fixes NOAA-EMC#356
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Oct 4, 2022
@WalterKolczynski-NOAA
Correct merge error in link script
1b7c418 
An incorrect resolution of a merge conflict resulted in an undefined
variable in the link script.

Refs: NOAA-EMC#356
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Oct 4, 2022
@WalterKolczynski-NOAA
Fix default missing var syntax error
c8ce296 
Corrects a `:-?` to `:?`.

Refs: NOAA-EMC#356
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this issue May 30, 2024
@climbfuji @grantfirl
Wrapper PR for "Update CCPP standard names for consistency (NOAA-EMC#337
fca8282 
)" (NOAA-EMC#356)

* update standard names in accordance with CCPPStandardNames PR#13 as of 2021/7/1
* Fix merge conflicts in ccpp/data/GFS_typedefs.meta

Co-authored-by: grantfirl <grantf@ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WalterKolczynski-NOAA WalterKolczynski-NOAA

Labels
coupled Issues related to the coupled branch feature New feature or request uncoupled Issues related to the uncoupled system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WalterKolczynski-NOAA