Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing atmos subfolder in dependency paths in workflow_tasks.py #997

Closed
KateFriedman-NOAA opened this issue Aug 25, 2022 · 0 comments · Fixed by #998
Closed

Missing atmos subfolder in dependency paths in workflow_tasks.py #997

KateFriedman-NOAA opened this issue Aug 25, 2022 · 0 comments · Fixed by #998
Assignees
Labels
bug Something isn't working

Comments

@KateFriedman-NOAA
Copy link
Member

The "atmos" subfolder part of the GDA dependency path for the prep and atmanalprep jobs is missing in the generated xmls for cycled mode. Looks like it got left out when the setup scripts were rewritten.

This line in workflow_tasks.py:

data = f'{dmpdir}/{self.cdump}{dump_suffix}.@Y@m@d/@H/{self.cdump}.t@Hz.updated.status.tm00.bufr_d'

...should be (includes "atmos"):

data = f'{dmpdir}/{self.cdump}{dump_suffix}.@Y@m@d/@H/atmos/{self.cdump}.t@Hz.updated.status.tm00.bufr_d'

Expected behavior

Prep and atmanalprep jobs start when they see the dependent updated.status file in the GDA.

Current behavior

Prep job does not start because it does not "see" the updated.status file because the dependency path is incorrect. This is currently only a bug for dates after WCOSS2 go-live because older dates in the GDA don't yet include the "atmos" subfolder and the files still live just under the cycle folder. There are symlinks in all GDA date subfolders to redirect users who have the updated dependency path that includes "atmos" for dates before WCOSS2 go-live. The "atmos" subfolder exists in the GDA after WCOSS2 go-live cycle.

Machines affected

All.

To Reproduce

Run any cycled test with CDATEs after WCOSS2 go-live (~2022062812).

Detailed Description

Add the missing "atmos" subfolder into the dependency paths in workflow_tasks.py.

@KateFriedman-NOAA KateFriedman-NOAA added the bug Something isn't working label Aug 25, 2022
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Aug 25, 2022
KateFriedman-NOAA added a commit that referenced this issue Aug 25, 2022
- The "atmos" subfolder in the GDA was missing in the dependency path
for the prep and atmanalprep jobs. Add it in for correctness.
- Updated dependencies in workflow/rocoto/workflow_tasks.py.

Refs: #997
KateFriedman-NOAA added a commit that referenced this issue Aug 25, 2022
The "atmos" subfolder in the GDA was missing in the dependency path for the prep and atmanalprep jobs. Add it in for correctness. Updated dependencies in workflow/rocoto/workflow_tasks.py.

Refs: #997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant