Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TC_tracker tag to v1.1.15.6 for Jet support #1491

Conversation

KateFriedman-NOAA
Copy link
Member

Description

This PR updates the TC_tracker version to v1.1.15.6 in parm/config/config.vrfy. This new tag includes the following updates:

  • Jet support
  • move R&D platforms to use EPIC hpc-stacks

Resolves #1463

Type of change

External package update.

How Has This Been Tested?

  • Clone and Build tests on all supported platforms
  • Cycled test on Hera, Orion, Jet

@KateFriedman-NOAA KateFriedman-NOAA added maintenance Regular updates and maintenance work port Porting the system to a new platform labels Apr 20, 2023
@KateFriedman-NOAA KateFriedman-NOAA self-assigned this Apr 20, 2023
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want this tracker system to be turned into one line prepobs, fit2obs, etc?
Or is that too much work and not worth it?

@KateFriedman-NOAA
Copy link
Member Author

do we want this tracker system to be turned into one line prepobs, fit2obs, etc? Or is that too much work and not worth it?

I don't see it being much work to add a modulefile in tracker to load it like prepobs/fit2obs. Whether it's set from g-w config.vrfy or our modulefiles it's the same....whichever one we use will be updated soon to use a version variable. Although, being in our modulefile would further consolidate things and be good when we move the tracker out of the vrfy job. My vote would be to do this.

Perhaps after the COM reorg updates in the tracker are complete?

Would need to discuss with @JiayiPeng-NOAA. @aerorahul Are you thinking of adding the modulefile ability for just development or also operations (e.g. like prepobs)?

Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have installed this on S4 as well and will work towards getting that port incorporated into future tags.

@KateFriedman-NOAA KateFriedman-NOAA merged commit 3594289 into NOAA-EMC:develop Apr 20, 2023
@KateFriedman-NOAA KateFriedman-NOAA deleted the feature/tc_tracker_tag_v1.1.15.6 branch April 20, 2023 14:00
@JiayiPeng-NOAA
Copy link

JiayiPeng-NOAA commented Apr 20, 2023 via email

@aerorahul
Copy link
Contributor

Hi Kate, This tracker version is only for development. We have a separate version for operational. Thanks, Jiayi

On Thu, Apr 20, 2023 at 9:57 AM Kate Friedman @.> wrote: do we want this tracker system to be turned into one line prepobs, fit2obs, etc? Or is that too much work and not worth it? I don't see it being much work to add a modulefile in tracker to load it like prepobs/fit2obs. Whether it's set from g-w config.vrfy or our modulefiles it's the same....whichever one we use will be updated soon to use a version variable. Although, being in our modulefile would further consolidate things and be good when we move the tracker out of the vrfy job. My vote would be to do this. Perhaps after the COM reorg updates in the tracker are complete? Would need to discuss with @JiayiPeng-NOAA https://github.com/JiayiPeng-NOAA. @aerorahul https://github.com/aerorahul Are you thinking of adding the modulefile ability for just development or also operations (e.g. like prepobs)? — Reply to this email directly, view it on GitHub <#1491 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRTVNOILN257J3H4PPLEZTXCE6FVANCNFSM6AAAAAAXFRC2QI . You are receiving this because you were mentioned.Message ID: @.>
@KateFriedman-NOAA

I think we can simply do the modulefile addition. Leave the internals to tracker project.
Updating the project to CMake, packaging etc. is likely not useful here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Regular updates and maintenance work port Porting the system to a new platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the TC tracker to incorporate Jet support
4 participants