Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/crow merge #20

Closed
wants to merge 10 commits into from
Closed

Feature/crow merge #20

wants to merge 10 commits into from

Conversation

JianKuang-Intelsat
Copy link
Contributor

Add CROW configurator and surrounding files (YAML) needed.

CROW is a Python-based configuration toolbox, developed through an object-oriented
programming approach using python. The goal of CROW is to drastically simplify the most
time-consuming and error-prone stages of executing a workflow, such as platform adaptation,
resource allocation and model configuration. This means more creative work could be done with
given resources, in terms of both user hours and computer capacity. Highly human-readable
YAML definition files are taken as input of CROW, and Rocoto or ecFlow definition file are
generated automatically at the end.

CROW github page: https://github.com/NOAA-EMC/CROW

@@ -0,0 +1,206 @@
# Jian Kuang 2019/09/04: renamed it to *_hold, prepare to remove
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this note should this file be removed?

EXPROOT: !error Please select a EXPROOT directory.
HOMEgfs: !calc ( tools.realpath(tools.abspath("../../")) )
HOMEcrow: !calc tools.crow_install_dir()
HOMEobsproc_prep: !expand "{doc.platform.BASE_GIT}/obsproc/obsproc_global.v3.2.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "obsproc_prep_RB-5.2.0" instead of "obsproc_global.v3.2.3" for HOMEobsproc_prep.

# DMPDIR - location of the global dump data. This is used by the observation
# processing scripts, which are not included in the public release.
DMPDIR: "/scratch1/NCEPDEV/global/glopara/dump"
NWPROD: "/scratch1/NCEPDEV/global/glopara/svn/verif/global/tags/vsdb/nwprod"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NWPROD on Hera should be "/scratch1/NCEPDEV/global/glopara/nwpara"

# processing scripts, which are not included in the public release.
DMPDIR: "/scratch1/NCEPDEV/global/glopara/dump"
NWPROD: "/scratch1/NCEPDEV/global/glopara/svn/verif/global/tags/vsdb/nwprod"
RTMFIX: "/scratch2/NCEPDEV/nwprod/NCEPLIBS/fix/crtm_v2.2.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTMFIX should be "$CRTM_FIX" on all platforms, taken from crtm module that gets loaded.

@KateFriedman-NOAA
Copy link
Member

Jian, I will need to do a detailed review and then test this feature branch. I will begin the fuller reviewer later this week and find time to test it. I will send questions I have.

The first question I have is this...I see references to ocn post and ice but we don't support those components in the current "develop" version of the system, are those copied over from your coupled CROW work? Also, you can remove all references to Theia now.

christopherwharrop-noaa referenced this pull request in NOAA-GSL/global-workflow May 11, 2020
 Update ufs_util to release/v2.0.0 which includes

    A few sea ice related issues in the NSST analysis: Issue #18 (#20)
    Updates to global_cycle:  Tf analysis for the grids with sea ice done using a salinity dependent formula (instead of using 271.2 K).   Update sfcsub.F to the latest version used by the forecast model (includes elimination of masked interpolation for substrate temperature and some updates to Fortran 90 standards).  The global_cycle.sh script was updated to reference a new global salinity dataset.
    Updates to global_chgres - Update sfcsub.F to use same version as global_cycle.

    Feature/hera port (#25)
    Update repository to run on Hera, the replacement for Theia.
    Remove all references to Theia.
zhanglikate pushed a commit to zhanglikate/global-workflow that referenced this pull request Mar 22, 2021
additional changes to run in realtime
lgannoaa pushed a commit to lgannoaa/global-workflow that referenced this pull request Feb 9, 2022
* Incorprate couple new computations from Jesse Meng such ad ESRH, DCAPE, Critical Angle.

* Add a fix for defining LFC HGT.

* Use new grib2 abbrev "DCAPE", "DCAPE", "ESP".

* Use NCEP table for new variables, e.g. DCAPE.

* Add changes for defining ESP.

* Add further changes for 8 new varaibles for hrrr/rap implementation.
zhanglikate pushed a commit to zhanglikate/global-workflow that referenced this pull request Oct 6, 2022
* update FMS to point to tag 2019.01 of NOAA-GFDL
* update stochastic_physics to point to hash 1745422af76d830757cd6035b6ea101e92b4cac1 @pjpegion
* update of path to CCPP physics library for CCPP regression tests
* add -Wall to compiler flags for GNU compilers
* remove warnings for non-existent include directories for GNU compiler
* update of regression testing scripts to detect errors in tests/run_test.sh
* new regression tests fv3_ccpp_gfs_v15p2, fv3_ccpp_gfs_v15p2_debug, fv3_ccpp_gfs_v16beta, fv3_ccpp_gfs_v16beta_debug
* update of rt.conf: remove Cheyenne.intel entries (so that rt.conf is an EMC-maintained regression test configuration; move Cheyenne Intel tests into a separate file that resides in the NCAR dtc/develop branch)
* make compile_cmake.sh work with Cheyenne Intel/GNU, and bugfixes for compile_cmake.sh
* allow environment variable NEMS_MACHINE to overwrite (or set) MACHINE_ID (see NOAA-EMC#20 for the corresponding PR for the ufs_public_release branch)
* new regression test fv3_ccpp_gsd_sar_25km_debug (but not exercised in default rt.conf)
* updates for jet and gaea (note: only supporting rt.sh, not NEMSCompsetRun)
zhanglikate pushed a commit to zhanglikate/global-workflow that referenced this pull request Oct 6, 2022
PBL tendencies were missing in two schemes; now fixed. Squashed commit of the following:

* fix bugs found in pbl and ozone 3d diagnostic tendencies
* remove debugging prints
* implied shape arrays for five variables
* more block labels in CCPP
* yet more bug fixes in ccpp
* make the logging less wordy
* point to hash 238c84cb3c789056c701b70d3373e640ed4fa599 of ccpp/physics
* point to merged version of FV3, with latest ldiag3d/qdiag3d bug fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants