-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor rocoto task XML creation #2189
Merged
aerorahul
merged 11 commits into
NOAA-EMC:develop
from
WalterKolczynski-NOAA:feature/ens_atmos_prod
Jan 8, 2024
Merged
Refactor rocoto task XML creation #2189
aerorahul
merged 11 commits into
NOAA-EMC:develop
from
WalterKolczynski-NOAA:feature/ens_atmos_prod
Jan 8, 2024
Commits on Dec 22, 2023
-
Refactor rocot task XML creation
Refactors the rocoto task generation to be recursive. This will allow nested metatasks to loop over multiple variables, which is needed for GEFS product generation. As part of this refactor, there is no longer separate arguments to designate metatasks. Instead, task dicts can include a nested 'task_dict' as well as a 'var_dict' containing the variables to loop over. The nested task dict can then either have another layer, or be the innermost task. To accomodate the new recursive nature, some defaults that were previously defined in `create_wf_task()` had to be pushed down into the function that creates the innermost task. Also, former keywords have been absorbed by the task dict. Refs NOAA-EMC#823 Refs NOAA-EMC#827
Configuration menu - View commit details
-
Copy full SHA for b009106 - Browse repository at this point
Copy the full SHA b009106View commit details
Commits on Dec 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 685de59 - Browse repository at this point
Copy the full SHA 685de59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be6c2f - Browse repository at this point
Copy the full SHA 3be6c2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b8594b - Browse repository at this point
Copy the full SHA 8b8594bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cb3cf3 - Browse repository at this point
Copy the full SHA 5cb3cf3View commit details
Commits on Jan 5, 2024
-
Remove global-specific variable from rocoto.py
Returns `rocoto.py` to a workflow-agnostic state without needing `cdump` or any rocoto entities. The middle-man `create_wf_task` in task.py is also removed by explicitly setting several keys in the task dict.
Configuration menu - View commit details
-
Copy full SHA for f16502c - Browse repository at this point
Copy the full SHA f16502cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3225bce - Browse repository at this point
Copy the full SHA 3225bceView commit details -
Configuration menu - View commit details
-
Copy full SHA for d95c718 - Browse repository at this point
Copy the full SHA d95c718View commit details
Commits on Jan 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c2189a8 - Browse repository at this point
Copy the full SHA c2189a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80a6545 - Browse repository at this point
Copy the full SHA 80a6545View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c44986 - Browse repository at this point
Copy the full SHA 2c44986View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.