Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link ensemble analysis increment files to COMROOT for warm_start #2553

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Link ensemble analysis increment files to COMROOT for warm_start #2553

merged 1 commit into from
Apr 30, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Apr 29, 2024 •
edited
Loading

Description

Scripting is added to setup_expt.py to link ensemble analysis increment files to COMROOT for warm_start experiments.

Resolves #2552

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on Orion
  • Run C96C48_ufs_hybatmDA on Orion

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@RussTreadon-NOAA
Copy link
Contributor Author

Will mark PR for ready once Orion testing is complete.

@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Apr 29, 2024
Closed
7 tasks
@RussTreadon-NOAA
Copy link
Contributor Author

Orion test
C96C48_ufs_hybatmDA (JEDI ATM CI) successfully ran the first half cycle using warm start initial conditions. C96C48_hybatmDA (GSI ATM CI), a cold start test, has also been launched on Orion. The first half cycle completed successfully. The revised setup_expt.py works for warm start and does not alter cold start behavior.

Additionally the JEDI ATM CI 2024022400 gfsfcst ran to completion. The GSI ATM CI test has not yet run the 2021122100 gfsfcst.

Hera test
C96C48_ufs_hybatmDA (JEDI ATM CI) and C96C48_hybatmDA (GSI ATM CI) successfully ran the first half cycle. Additionally, both the JEDI and GSI based parallels successfully ran the gfsfcst in the first full cycle.

The successful gfsfcst is contrary to what issue #2551 reports. This issue was using an older snapshot of g-w. Perhaps recent commits resolved whatever caused the gfsfcst failures reported in #2551. Another possibility is that the errors reported in #2551 were due to system errors, not g-w problems.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review April 29, 2024 19:12
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Apr 29, 2024
Closed
@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Apr 29, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

Orion GSI ATM CI also successfully ran 2021122100 gfsfcst. So on both Orion and Hera the 00Z gfsfcst now successfully runs.

WalterKolczynski-NOAA
WalterKolczynski-NOAA approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved pending successful completion of CI tests.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Apr 29, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Apr 29, 2024
@emcbot
Copy link

emcbot commented Apr 30, 2024

CI Passed Hera at
Built and ran in directory /scratch1/NCEPDEV/global/CI/2553

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 2ecf4f8 into NOAA-EMC:develop Apr 30, 2024
9 of 10 checks passed
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request May 2, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
647282e 
* upstream/develop:
  Update gfs_utils for Gaea (NOAA-EMC#2556)
  Updated GEMPAK version and APRUN launcher. (NOAA-EMC#2555)
  Utilize scale-dependent localization for atmospheric analysis (NOAA-EMC#2542)
  Remove implicit symlink names (NOAA-EMC#2527)
  Fixes sea ice archiving (NOAA-EMC#2541)
  Link ensemble analysis increment files to COMROOT for warm_start (NOAA-EMC#2553)
  Launch Multiple Platforms to Jenkins with polling (NOAA-EMC#2548)
  Turn C48mx500_3DVarAOWCDA back on  (NOAA-EMC#2543)
  Add option to link different orog/ugwd fix files for global nest (NOAA-EMC#2532)
  Retire AWIPS GRIB1 products (NOAA-EMC#2547)
  Add CADS use flexibility (NOAA-EMC#2540)
  Hot fix for bash CI on WCOSS2 (NOAA-EMC#2536)
  Fix comment indentation (NOAA-EMC#2526)
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request May 3, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/build_je…
66eab64 
…di_exe

* upstream/develop:
  Add nest capability (NOAA-EMC#2545)
  Update gfs_utils for Gaea (NOAA-EMC#2556)
  Updated GEMPAK version and APRUN launcher. (NOAA-EMC#2555)
  Utilize scale-dependent localization for atmospheric analysis (NOAA-EMC#2542)
  Remove implicit symlink names (NOAA-EMC#2527)
  Fixes sea ice archiving (NOAA-EMC#2541)
  Link ensemble analysis increment files to COMROOT for warm_start (NOAA-EMC#2553)
  Launch Multiple Platforms to Jenkins with polling (NOAA-EMC#2548)
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/ens_warm_start branch May 14, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link ensemble ratminc files for warm_start CI
3 participants
@RussTreadon-NOAA @emcbot @WalterKolczynski-NOAA