Fix NST_SPINUP being ignored by CROW #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NSST config file was setting NST_SPINUP to use an environment variable rather than using the value set by the yaml, so values set in the case file were ignored. Refs: NOAA-EMC#337
WalterKolczynski-NOAA
added
bug
|
Note: I didn't actually run the model, I just confirmed that the config.nsst file is now exporting the value set in the yaml. |
KateFriedman-NOAA
approved these changes
Jun 22, 2021
rmontuoro
approved these changes
Jun 22, 2021
|
Going to merge this one, since it is clearly a bug, then we can deal with any additional changes needed for NSST separately. |
aerorahul
pushed a commit
that referenced
this pull request
Jul 12, 2022
GitHub Issue NOAA-EMC/GSI#341. Update the use of MW radiances for GFS v16.3 implementation
aerorahul
pushed a commit
that referenced
this pull request
Jul 12, 2022
GitHub Issue NOAA-EMC/GSI#341. Update the use of MW radiances for GFS v16.3 implementation
kayeekayee
pushed a commit
to kayeekayee/global-workflow
that referenced
this pull request
May 30, 2024
…ve snet from noah lsm, fix time dimension in restart files (NOAA-EMC#350) - Update of submodule pointers for ccpp-physics for the changes listed below - Thompson inner loop from @RuiyuSun - Thompson subcycling bugfix from @climbfuji - Noah/NoahMP bugfix/remove snet from Noah LSM from @HelinWei-NOAA - Fix time dimension in restart files from @climbfuji Co-authored-by: Helin Wei <Helin.Wei@noaa.gov> Co-authored-by: Ruiyu Sun <Ruiyu.Sun@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NSST config file was setting NST_SPINUP to use an environment variable rather than using the value set by the yaml, so values set in the case file were ignored.
Refs: #337