Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to run "base" s2s-prototype4 #80

Conversation

JessicaMeixner-NOAA
Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Jun 2, 2020

This PR is for running the "base" case of prototype 4. This means checking out and building the updated tag of ufs-s2s-model s2s_prototype4.0, running with CCPP (suite file FV3_GFS_v15p2_coupled), updated oro data with lakes (using new fix file directories), but not running with wave coupling. Other updates include:

  • clean up of various scripts
  • updated input files to match p4 base case
  • updated module files on Orion so that both forecast job and post will run
  • adding first pass of wave scripts in preparation for adding waves later
  • Using group account location on hera
  • Updates to IC script to conform to new data storage structure of ICs

This does not include:

  • ocean/ice post for orion
  • ocean/ice post on hera not pointing to a personal file location
  • turning on wave coupling options

Before this PR is accepted, someone else should test that they can replicate on hera that everything works including the updated tar file archiving structure and on orion that they can run the IC, forecast job and atm posts. I'm slightly worried that what someone has in their .bashrc on orion will interfere with successfully running forecast/atm post on orion.

making readme consistant with user.yaml.default
…i cplwav model_config block. Reinstating config.wave block in JGLOBAL_FORECAST. Pointing EXECwave to HOMEgfs/exec directory for WW3 util executables (changed link_fv3gfs.sh accordingly). Removing debug options from compile.sh line in build_fv3.sh.
IC for s2s model and made it platform dependent.
(Orion location is temporary and needs to be replaced, can also be
changed in cases/coupled_free_forecast.yaml to users prefered location)
copying suite xml file to rundirectory
post jobs for atmosphere are no longer triggered on cold starts
@JessicaMeixner-NOAA
Copy link
Contributor Author

@JianKuang-NOAA I wanted to add Lydia @LydiaStefanova-NOAA and Jiande @jiandewang as reviewers but could not.

@JessicaMeixner-NOAA JessicaMeixner-NOAA changed the title Updates to run "base Updates to run "base" s2s-prototype4 Jun 2, 2020
@KateFriedman-NOAA
Copy link
Member

@JianKuang-NOAA I wanted to add Lydia @LydiaStefanova-NOAA and Jiande @jiandewang as reviewers but could not.

Neither of them are in the NOAA-EMC org member list...that may be why. I have sent them both invites to join the org.

@JianKuang-Intelsat
Copy link
Contributor

@JessicaMeixner-NOAA This PR contains J_* scripts and build/link updates, along with some overlaps with my work. I think this should be merged first before my updates, which may be more Orion-specific.

Copy link
Contributor

@JianKuang-Intelsat JianKuang-Intelsat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow runs fine on Orion, ready for next step.

@JessicaMeixner-NOAA
Copy link
Contributor Author

@JianKuang-NOAA, in reference to the issue @LydiaStefanova-NOAA saw, is there a way to purge a users modules before the forecast job runs or do we need to add a note in the README that users might need to purge modules if conflicts arise and cause the forecast job to fail?

@JianKuang-Intelsat
Copy link
Contributor

@JessicaMeixner-NOAA COuld you please (re)send me an email about the issue that you are talking about? In general, user-loaded modules shouldn't affect the job because the modules are handled by ush/load_fv3gfs_modules.sh script. I need to get more in-detail description about the issue.

@LydiaStefanova-NOAA
Copy link

LydiaStefanova-NOAA commented Jun 2, 2020 via email

@JianKuang-Intelsat
Copy link
Contributor

@JessicaMeixner-NOAA @LydiaStefanova-NOAA I found the issue:

The following lines of script ush/load_fv3gfs_modules.sh do not work:

Find module command and purge:

source "$HOMEgfs/modulefiles/module-setup.sh.inc"

The fix is easy. I will include it in my later PR. How's that sounds like?

@JianKuang-Intelsat
Copy link
Contributor

@JessicaMeixner-NOAA Could we merge it now or still wait for some testings?
PS: I am not able to run the test at any machine other than Orion.

@JessicaMeixner-NOAA
Copy link
Contributor Author

@JianKuang-NOAA there are still some issues with ocean-post, but we could probably merge it now and then fix those as a next step. the forecast and atm post should work without issues on both hera and orion.

@JianKuang-Intelsat JianKuang-Intelsat merged commit bf34181 into NOAA-EMC:feature/coupled-crow Jun 5, 2020
@bingfu-NOAA
Copy link
Contributor

Should we change OCN_FHRLST: !calc "tools.seq(dimval.fhr, dimval.fhr+doc.output_settings.OCN_INTERVAL, 6)" to OCN_FHRLST: !calc "tools.seq(dimval.fhr, dimval.fhr+doc.output_settings.OCN_INTERVAL-6, 6)"? because there is one cycle was double processed (see below) when we do ocean post.
sh -c ' source $HOMEgfs/ush/load_fv3gfs_modules.sh exclusive ; module list ; export OCN_FHRLST="[0, 6, 12, 18, 24]"; $HOMEgfs/jobs/rocoto/ocnpost.sh'
sh -c ' source $HOMEgfs/ush/load_fv3gfs_modules.sh exclusive ; module list ; export OCN_FHRLST="[24, 30, 36, 42, 48]"; $HOMEgfs/jobs/rocoto/ocnpost.sh'
sh -c ' source $HOMEgfs/ush/load_fv3gfs_modules.sh exclusive ; module list ; export OCN_FHRLST="[48, 54, 60, 66, 72]"; $HOMEgfs/jobs/rocoto/ocnpost.sh'
sh -c ' source $HOMEgfs/ush/load_fv3gfs_modules.sh exclusive ; module list ; export OCN_FHRLST="[72, 78, 84, 90, 96]"; $HOMEgfs/jobs/rocoto/ocnpost.sh'
sh -c ' source $HOMEgfs/ush/load_fv3gfs_modules.sh exclusive ; module list ; export OCN_FHRLST="[96, 102, 108, 114, 120]"; $HOMEgfs/jobs/rocoto/ocnpost.sh'
sh -c ' source $HOMEgfs/ush/load_fv3gfs_modules.sh exclusive ; module list ; export OCN_FHRLST="[120, 126, 132, 138, 144]"; $HOMEgfs/jobs/rocoto/ocnpost.sh'
sh -c ' source $HOMEgfs/ush/load_fv3gfs_modules.sh exclusive ; module list ; export OCN_FHRLST="[144, 150, 156, 162, 168]"; $HOMEgfs/jobs/rocoto/ocnpost.sh'
sh -c ' source $HOMEgfs/ush/load_fv3gfs_modules.sh exclusive ; module list ; export OCN_FHRLST="[168, 174, 180, 186,

@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the feature/coupled-crow-addWW3jobs branch September 1, 2020 16:00
lgannoaa pushed a commit to lgannoaa/global-workflow that referenced this pull request Feb 9, 2022
zhanglikate pushed a commit to zhanglikate/global-workflow that referenced this pull request Oct 6, 2022
* Update FV3 submodule

* Regression test log files on Hera

* Regression test log files on WCOSS Cray

* Regression test log files on WCOSS Dell

* Update FV3 submodule
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants