Fixes regional diagnostic error (issue # 409) by adding global attrib… #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute NumFilesInSet and per-axis attribute domain_decomposition for regional X and Y axis.
… and per-axis attribute "domain_decomposition" for regional X and Y axis. NumFilesInSet is always set equal to 0. Fixes errors in writing regional diagnostics using mask tables.
colingladueNOAA
added
the
bug
… NumFilesInSet and domain_decomposition attributes.
thomas-robinson
requested changes
May 29, 2020
…utes NumFilesInSet and domain_decomposition for regional subaxis. Presence of NumFileInSet is checked so as to add it only once. Relevant comments are added. This solves github issue # 409.
…utes NumFilesInSet and domain_decomposition for regional subaxis. Presence of NumFileInSet is checked so as to add it only once. Relevant comments are added. This solves github issue # 409.
…esInSet" oce per regional diag file - in function diag_output_init. Function write_axis_meta_data is modified to register the attribute "domain_decomposition" for regional X and Y axis. NumFilesInSet is always set equal to 0. Appropriate comments are added.
|
Per the decisions in the FMS2_IO meeting on Jun 1, I moved the registering of the global attribute NumFileInSet back tnto the function "diag_output_init()" |
wrongkindofdoctor
approved these changes
Jun 1, 2020
thomas-robinson
approved these changes
Jun 2, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors in writing regional diagnostics using mask tables by registering global attribute "NumFilesInSet" and per-axis attribute "domain_decomposition" for regional X and Y axis.
NumFilesInSet is always set equal to 0. File diag_output.F90 was changed.
Fixes #409
How Has This Been Tested?
Ocean model output for regional diagnostic with mask tables were performed on Xanadu and 2020.02 code base (plus this fix) and compared.
Checklist:
make distcheckpasses