Minor changes to remove two newer compiler warnings #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of constant in make_coupler_mosaic and adding const qualifier to char * in declaration of print_provenance_info.
ceblanton
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for two minor changes to the code to remove new compiler warnings from two recent code changes. First, the redefinition of constants R2D and D2R are removed from make_coupler mosaic since they are already defined in the included constant.h file. This change was missed in an earlier merge.
Second, print_provenance_info functions are getting a const qualifier to "char * history"
argument. This does not have a functional effect but removed a warning introduced within the
last year.