(*)Fix ice shelf dimensional rescaling bugs #126
Conversation
Fixed two minor bugs in the ice-shelf code that impede its performance when dimensional scaling is used. - Report rescaling factors of 1 in the ice shelf restart files, now that the variables are rescaled before being written to the restart files. Without this change, certain runs with enabled ice shelf capabilities will not reproduce across restarts when dimensional rescaling is enabled. - Pass the unit scaling type to the EOS_init call. Without this change, cases with an active ice shelf will not pass dimensional rescaling tests if there is a nonlinear equation of state. All answers are bitwise identical without dimensional rescaling or an active ice shelf, but in some cases answers will be changed so that now the code will pass some reproducibility tests.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #126 +/- ##
=========================================
Coverage 33.45% 33.45%
=========================================
Files 262 262
Lines 71385 71385
Branches 13323 13323
=========================================
Hits 23884 23884
Misses 43029 43029
Partials 4472 4472
Continue to review full report at Codecov.
|
|
Olga Sergienko will be providing a review of this PR after she gets back from the EGU meeting. If she has not done this yet, this PR can be temporarily bypassed. |
|
Upon further reflection, although this PR deals with code in the ice-shelf directory, it really is not specific to ice-shelves, and does not require ice-shelf subject matter expertise. Unlike PR # 130, this PR can be dealt with without waiting for Olga's review. |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15711 ✔️ |
Add non-interval restart capability
Fixed two minor bugs in the ice-shelf code that impede its performance when
dimensional scaling is used.
Report rescaling factors of 1 in the ice shelf restart files, now that the
variables are rescaled before being written to the restart files. Without
this change, certain runs with enabled ice shelf capabilities will not
reproduce across restarts when dimensional rescaling is enabled.
Pass the unit scaling type to the EOS_init call. Without this change,
cases with an active ice shelf will not pass dimensional rescaling tests
if there is a nonlinear equation of state.
All answers are bitwise identical without dimensional rescaling or an active ice
shelf, but in some cases answers will be changed so that now the code will pass
some reproducibility tests.