+Clean up dimensional rescaling in OBC code #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new scale argument to time_interp_external to standardize where the dimensional rescaling occurs for the OBC code, and to use properly dimensionally rescaled internal variables. This includes the addition of the new function scale_factor_from_name, and there are new verticalGrid_type and unit_scale_type arguments to initialize_segment_data. All answers are bitwise identical and are passing dimensional consistency testing, including in Alex Bozec's Gulf of Mexico regional configuration, but there are new arguments to public interfaces.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #138 +/- ##
============================================
- Coverage 33.45% 33.45% -0.01%
============================================
Files 262 262
Lines 71413 71436 +23
Branches 13336 13340 +4
============================================
+ Hits 23891 23896 +5
- Misses 43048 43066 +18
Partials 4474 4474
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15758 ✔️ |
marshallward
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new scale argument to time_interp_external to standardize where the
dimensional rescaling occurs for the OBC code, and to use properly dimensionally
rescaled internal variables. This includes the addition of the new function
scale_factor_from_name, and there are new verticalGrid_type and unit_scale_type
arguments to initialize_segment_data. All answers are bitwise identical and
are passing dimensional consistency testing, including in Alex Bozec's Gulf of
Mexico regional configuration, but there are new arguments to public interfaces.