Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GWD, LSM and MYNN physics updates from RRFS_dev branch #142

Conversation

mdtoyNOAA
Copy link
Collaborator

@mdtoyNOAA mdtoyNOAA commented Mar 24, 2022

Description:

This PR updates CCPP physics modules for the gravity wave drag (GWD), LSM and MYNN surface layer parameterization. These updates are from the RRFS_dev branch.

  1. GWD — drag_suite.F90: Removed limits on standard deviation of small-scale topography used by the small-scale GWD and turbulent orographic form drag (TOFD) schemes of the GSL drag suite. Removed the height limitation of the TOFD scheme.

  2. LSM:

    There are a few changes in GFS_surface_composites.F90
    1. Added lat/lon to the parameter list for debugging purposes.
    2. Flag_restart is replaced with lsm_cold_start - no impact on the result.
    3. Removed snow initialization with the use of RUC LSM. In case of a cold
    start, snow on land or on ice is initialized in io/FV3GFS_io.F90. In case of
    a warm start, these variables are carried along.
    3. Corresponding changes in GFS_surface_composites.meta.

For module_sf_ruclsm.F90
   1. In computation of soil resistance to evaporation use soil moisture field capacity with factor 1. instead of 0.7. 
      This change will reduce direct evaporation from the bare soil.

  1. MYNN sfc_layer — module_sf_mynn.F90: changed "compute_flux" logical parameter from .false. to .true.

This PR changes the results, so baseline results were created by the Regression Tests.

The following RT's passed:
Hera - Intel — baseline results at: /scratch1/BMC/wrfruc/mtoy/stmp4/Michael.Toy/FV3_RT/REGRESSION_TEST_INTEL.2022_03_25
Hera - GNU — baseline results at: /scratch1/BMC/wrfruc/mtoy/stmp4/Michael.Toy/FV3_RT/REGRESSION_TEST_GNU.2022_03_25
Jet — Intel — baseline results at: /lfs4/BMC/wrfruc/mtoy/RT_BASELINE/Michael.Toy/FV3_RT/REGRESSION_TEST_INTEL.2022_03_25

@SamuelTrahanNOAA
Copy link
Collaborator

@mdtoyNOAA You need to merge the latest changes from gsl/develop (see #119) which also change results. That means you will need to regenerate the baselines.

@SamuelTrahanNOAA SamuelTrahanNOAA added bug Something isn't working enhancement New feature or request labels Mar 24, 2022
…into gsl/develop_physics_mods_from_RRFS_dev
@SamuelTrahanNOAA SamuelTrahanNOAA merged commit 8293f36 into NOAA-GSL:gsl/develop Mar 25, 2022
zhanglikate pushed a commit to zhanglikate/ccpp-physics that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants